V8ObjectUtils.setValue method supports array values#616
Open
Kathircpe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change adds proper support for arrays when calling
V8ObjectUtils.setValuewith minimal change in the existing code.How is it fixed?
A new
toListhas been created instead of usingArrays.asList(array)method in order to convert the array into a list topass it to
toV8Arraymethod.Why not the Arrays.asList() method?
Primitive arrays will wrapped as a single element due to
Arrays.asListvarargs behavior, resulting in nested output.The implementation now converts arrays using
java.lang.reflect.Arraybefore delegating to the existing list-processing logic. This ensures both
object arrays and primitive arrays are flattened correctly.
Why is this needed?
Arrays.asList()treats primitive arrays as a single element, which causedextra nesting layers in the resulting V8Array.
Related issue
Fixes #24