Skip to content

fix(android): align ELF segments to 16 KB pages for Android 15+ compliance (closes #605) #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phanendharreddy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(android): align ELF segments to 16 KB pages for Android 15+ compliance (closes #605) #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ set(CMAKE_CXX_STANDARD 14)
if(CMAKE_SYSTEM_NAME STREQUAL "Android")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wno-unused-function -Wno-unused-variable -O3 -funroll-loops -ftree-vectorize -ffast-math -fpermissive -fPIC ")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-unused-function -Wno-unused-variable -O3 -funroll-loops -ftree-vectorize -ffast-math -fpermissive -fPIC ")
#Align output ELF segments to 16 KB pages for Android 15+
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,max-page-size=16384")

endif()

# remove the MinSizeRel and RelWithDebInfo configurations
Expand Down
1 change: 1 addition & 0 deletions jni/Android.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ LOCAL_SRC_FILES := com_eclipsesource_v8_V8Impl.cpp
LOCAL_C_INCLUDES := $(LOCAL_PATH)/../node/node.$(TARGET_ARCH_ABI)/deps $(LOCAL_PATH)/../node/node.$(TARGET_ARCH_ABI)/deps/v8 $(LOCAL_PATH)/../node/node.$(TARGET_ARCH_ABI)/deps/v8/include $(LOCAL_PATH)/../node/node.$(TARGET_ARCH_ABI)/deps/icu-small/source
LOCAL_CFLAGS += -std=c++11 -Wall -Wno-unused-function -Wno-unused-variable -O3 -funroll-loops -ftree-vectorize -ffast-math -fpermissive -fPIC
LOCAL_LDLIBS += -L$(SYSROOT)/usr/lib -llog -latomic
LOCAL_LDFLAGS += -Wl,-z,max-page-size=16384

LOCAL_STATIC_LIBRARIES := \
v8_base v8_nosnapshot v8_libplatform v8_libbase v8_libsampler
Expand Down