Usubscription v4 - #358
Open
AnotherDaniel wants to merge 4 commits into
Open
Conversation
AnotherDaniel
commented
Jul 20, 2026
AnotherDaniel
commented
Contributor
- implement all changes required to support usubscription spec v4
- some dependency version bumps
sophokles73
reviewed
Jul 27, 2026
Contributor
|
@AnotherDaniel I have put most (if not all) of your proposed crate updates into a separate PR (#362). Can you take a look, approve and then rebase this PR? |
AnotherDaniel
force-pushed
the
usubscription_v4
branch
from
July 29, 2026 09:09
cf79e80 to
d877e7b
Compare
Contributor
|
@AnotherDaniel can you also resolve the conflicts with main? |
AnotherDaniel
force-pushed
the
usubscription_v4
branch
from
July 29, 2026 09:17
d877e7b to
68252c8
Compare
sophokles73
reviewed
Jul 29, 2026
AnotherDaniel
force-pushed
the
usubscription_v4
branch
from
July 29, 2026 09:21
68252c8 to
da85a53
Compare
AnotherDaniel
force-pushed
the
usubscription_v4
branch
from
August 25, 2026 12:43
d397956 to
0d26414
Compare
AnotherDaniel
force-pushed
the
usubscription_v4
branch
from
August 25, 2026 12:51
0d26414 to
a1c12c4
Compare
AnotherDaniel
added
enhancement
AnotherDaniel
force-pushed
the
usubscription_v4
branch
from
August 26, 2026 15:01
7e88b58 to
55bfc9a
Compare
sophokles73
reviewed
Aug 27, 2026
Contributor
|
It seems like you didn't push any of the changes that you mentioned in the comments ... |
Contributor
Author
Yes, you're right. git mishap - should be back now. |
AnotherDaniel
force-pushed
the
usubscription_v4
branch
from
August 28, 2026 13:25
3e23c62 to
b82ed96
Compare
sophokles73
reviewed
Aug 29, 2026
| /// at a high rate. If the desired sampling period set by the subscriber is lower than the original publisher's | ||
| /// publication period, the attribute is ignored. | ||
| /// If not specified, the sampling period is set by the publisher. | ||
| /// TimeDeltas used in `min_sample_period` will be clamped to [0; u32::MAX] milliseconds. |
Contributor
There was a problem hiding this comment.
What is the meaning of a TimeDelta of 0? In fact, who cares about this value anyway? The streamer? The publishing uEntity will most likely not care at all, right?
Is there a (reasonable) minimal delta that we would like to impose, maybe something like 100ms? We are talking about remote topics only here, right?
Contributor
Author
There was a problem hiding this comment.
Fair point, but I'd rather have the underlying discussion in up-spec context, before we address the language library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.