Repository navigation
chore(actions): migrate from dedicated version to sha - #66
Merged
Merged
Conversation
jSchuetz88
approved these changes
Nov 9, 2026
jSchuetz88
left a comment
Member
There was a problem hiding this comment.
Checked all references. LGTM.
In the cases where the reference was also slightly updated we need to check after merge, whether it still works as intended,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI agent for Eclipse Tractus-X KITs · what is this?
Posted through @stephanbcbauer's account at their request. I answer from the KITs, TRGs and files I opened, not from memory.
👋 Hi! I'm the KIT Master Builder — your Eclipse Tractus-X KIT architect.
Description
This PR pins the last thirteen GitHub Action references in this repository to full commit SHAs, in one commit, across three workflows. All other actions were already pinned.
actions/checkout@v73d3c42e5aac5ba805825da76410c181273ba90b1# v7.0.1actions/setup-go@v7b7ad1dad31e06c5925ef5d2fc7ad053ef454303e# v7.0.0actions/upload-artifact@v7cf430e030ddbb5b0abf93d22962f4752f3646cd9# v7.0.2Legion2/swagger-ui-action@v1eff65dc3f193f0a749872be82f74baa35be0797d# v1.3.0jayanta525/github-pages-directory-listing@v4.0.0624ac8c4e56893256d3772f61a88e3b14d54314e# v4.0.0peaceiris/actions-gh-pages@v484c30a85c19949d7eee79c4ff27748b70285e453# v4.1.0eclipse-tractusx/sig-infra/.github/actions/run-dash@main1a2be9d3b599c081a4a307d8124f33d209f7c54e# mainFiles (all under
.github/workflows/):publish_api.yaml(10),dash-licence-check.yaml(2),trufflehog.yml(1).Why: a version tag or branch can point to a different commit at any time. That is how the March 2026
trivy-actionsupply-chain attack worked (GHSA-69fq-xp46-6x23). A commit SHA can't be moved, so the workflows always run exactly the code that was reviewed. That matters here becausepublish_api.yamlpublishes the API hub to GitHub Pages.For the tagged actions, each SHA is the commit the tag used so far points to today, so the behaviour does not change. The trailing comment names the exact release, so readers and Dependabot can see the version.
run-dashfromsig-infra:sig-infrahas no release tags yet, so I pinned today'smainHEAD (1a2be9d3…, 2026-11-03), which already contains the latestrun-dashchange. Because there is no tag, Dependabot can't update this pin; updates have to be pulled in by hand untilsig-infrapublishes releases. The same approach is used in eclipse-tractusx/sig-release#1789.Notes for review:
trufflehog.ymlanddash-licence-check.yamlrun on pull requests, so CI on this PR exercises the pins there.publish_api.yamlruns on a schedule or manual dispatch.trufflehog.ymland does not conflict with this change.Pre-review checks
uses:lines are edited.Thanks for reviewing! 🏗️ Feel free to ask me anything in the comments.
How I checked this (and how you can reproduce it)
Checked against
main@cf51ffe:What I verified and what I only infer: I verified that every tag resolves to the pinned SHA (moving tag and exact release on the same commit), that
1a2be9d3…is the currentsig-inframainHEAD, and that the branch diff contains exactly these thirteenuses:lines in one commit. I infer that the workflows behave the same; the PR checks confirm it for the PR-triggered workflows.— KIT Master Builder 🏗️