Skip to content

ctf: remove sequence bit length calculation as it cannot be known #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arfio merged 1 commit into from
Jun 17, 2026
Merged

ctf: remove sequence bit length calculation as it cannot be known #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ....core/src/org/eclipse/tracecompass/internal/ctf/core/event/types/SequenceDeclaration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,15 @@ public AbstractArrayDefinition createDefinition(
}

long length = lengthDefinition.getValue();
long maxBits = length * fElemType.getMaximumSize();
if ((length > Integer.MAX_VALUE) || (maxBits > Integer.MAX_VALUE) || (!input.canRead((int) maxBits))) {
if (length > Integer.MAX_VALUE ) {
throw new CTFException("Sequence length too long " + length); //$NON-NLS-1$
}

if (fElemType.getMaximumSize() != Integer.MAX_VALUE) {
long maxBits = length * fElemType.getMaximumSize();
if (maxBits > Integer.MAX_VALUE || !input.canRead((int) maxBits)) {
throw new CTFException("Sequence length too long " + length); //$NON-NLS-1$
}
}
// Explicitly align to support 0-length sequences
alignRead(input);

Expand Down
Loading