Repository navigation
Conversation
arkjedrz
requested review from
PandaeDo,
antonkri and
vinodreddy-g
as code owners
October 29, 2026 08:44
arkjedrz
had a problem deploying
to
workflow-approval
October 29, 2026 08:44 — with 
GitHub Actions
Error
GitHub Actions
Error
arkjedrz
had a problem deploying
to
workflow-approval
October 29, 2026 08:44 — with
GitHub Actions
Error
GitHub Actions
Error
arkjedrz
changed the title
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
- Kvs::Open() takes the filesystem, the JSON parser and the JSON writer as required parameters. A null pointer violates a precondition, checked with the S-CORE assertion macro. - KvsBuilder::Build() and the deprecated open() pass the real objects. - Tests open the KVS through a file-local OpenKvs() helper. Its defaulted parameters supply the real objects, and tests pass mocks in their place. - Convert 6 tests to inject mocks and drive the public API. - Split the two filename failure tests into a real and a mock case. - Replace the no_parent_path sub-case with a public-API test for an empty working directory. It pins a known defect. - Add a death test for the null precondition. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
arkjedrz
force-pushed
the
arkjedrz_tests-03-cpp-fault-injection
branch
from
October 29, 2026 09:08
4923d74 to
9e26819
Compare
Contributor
|
Documentation preview for this pull request is available at: |
Ahmed-Elsaka-JC
suggested changes
Oct 29, 2026
| std::unique_ptr<score::json::IJsonParser> parser, | ||
| std::unique_ptr<score::json::IJsonWriter> writer) noexcept | ||
| { | ||
| SCORE_LANGUAGE_FUTURECPP_PRECONDITION_PRD_MESSAGE(filesystem != nullptr, "Kvs::Open: filesystem must not be null"); |
Contributor
There was a problem hiding this comment.
why do you mandate to have them as mandatory args .
why not makeing them optional parameters with defult value = nullptr then in testing scenario we can pass them but in normal use cases not passing them to open function ?
Contributor
Author
|
Halting the topic until #538 is fixed - approach will have to change. |
arkjedrz
marked this pull request as draft
October 30, 2026 13:05
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #574