Skip to content

kvs: global logger and enhanced logs - #608

Open
arkjedrz wants to merge 2 commits into
eclipse-score:mainfrom
qorix-group:arkjedrz_global-logger
Open

kvs: global logger and enhanced logs#608
arkjedrz wants to merge 2 commits into
eclipse-score:mainfrom
qorix-group:arkjedrz_global-logger

Conversation

@arkjedrz

@arkjedrz arkjedrz commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Add a global logger, accessible through internal/logger.h.
  • Remove logger_ field from Kvs.
  • Move functions no longer using any field to anonymous namespace.
  • Provide more obvious logs from Kvs.

Resolves #601

@arkjedrz arkjedrz self-assigned this Oct 27, 2026
@arkjedrz
arkjedrz deployed to workflow-approval October 27, 2026 14:01 — with GitHub Actions Active
@arkjedrz
arkjedrz deployed to workflow-approval October 27, 2026 14:01 — with GitHub Actions Active
@github-actions

github-actions Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: fdb6694f-0e89-49d2-bd91-2af0cc351b56
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (91 packages loaded, 14 targets configured)

Analyzing: target //:license-check (100 packages loaded, 14 targets configured)

Analyzing: target //:license-check (100 packages loaded, 14 targets configured)

Analyzing: target //:license-check (159 packages loaded, 3739 targets configured)

Analyzing: target //:license-check (201 packages loaded, 8553 targets configured)

Analyzing: target //:license-check (207 packages loaded, 11661 targets configured)

Analyzing: target //:license-check (207 packages loaded, 11661 targets configured)

Analyzing: target //:license-check (207 packages loaded, 11661 targets configured)

Analyzing: target //:license-check (210 packages loaded, 13546 targets configured)

Analyzing: target //:license-check (211 packages loaded, 17633 targets configured)

INFO: Analyzed target //:license-check (213 packages loaded, 17903 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 50 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/tools/formatted.txt
[15 / 16] [Prepa] Building tools/license.check.license_check.jar ()
INFO: Found 1 target...
Target //tools:license.check.license_check up-to-date:
  bazel-bin/tools/license.check.license_check
  bazel-bin/tools/license.check.license_check.jar
INFO: Elapsed time: 47.803s, Critical Path: 2.32s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/tools/license.check.license_check tools/formatted.txt <args omitted>
[main] INFO Querying Eclipse Foundation for license data for 42 items.
[main] INFO Found 32 items.
[main] INFO Querying ClearlyDefined for license data for 10 items.
[main] INFO Found 10 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO crate/cratesio/-/lazy_static/1.5.1
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.

@github-actions

github-actions Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-608: https://eclipse-score.github.io/persistency/pr-608/

@arkjedrz
arkjedrz force-pushed the arkjedrz_global-logger branch from 0515db9 to b284a99 Compare October 28, 2026 06:36
@arkjedrz
arkjedrz force-pushed the arkjedrz_global-logger branch from b284a99 to 0622fc1 Compare October 28, 2026 13:03
@arkjedrz
arkjedrz force-pushed the arkjedrz_global-logger branch from 0622fc1 to 03696db Compare October 28, 2026 15:06
@arkjedrz
arkjedrz force-pushed the arkjedrz_global-logger branch from 03696db to ce3ff40 Compare October 28, 2026 16:15
@arkjedrz
arkjedrz force-pushed the arkjedrz_global-logger branch from ce3ff40 to c35f160 Compare October 29, 2026 08:39
karolnowak
karolnowak approved these changes Oct 29, 2026
View reviewed changes

@karolnowak karolnowak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, we might change this approach in the future.

@arkjedrz
arkjedrz force-pushed the arkjedrz_global-logger branch from c35f160 to 4b201d5 Compare October 29, 2026 14:12
@arkjedrz
arkjedrz force-pushed the arkjedrz_global-logger branch from 4b201d5 to b6b66e3 Compare October 30, 2026 13:57
github-advanced-security[bot]
github-advanced-security Bot found potential problems Oct 30, 2026
View reviewed changes
Comment thread score/kvs/kvs.cpp Fixed
Comment thread score/kvs/kvs.cpp Fixed
Comment thread score/kvs/kvs.cpp Fixed
Comment thread score/kvs/kvs.cpp Fixed
Comment thread score/kvs/kvs.cpp Fixed
Comment thread score/kvs/kvs.cpp Fixed
Comment thread score/kvs/internal/logger.h Fixed
Comment thread score/kvs/kvs.cpp Fixed
Comment thread score/kvs/kvs.cpp Fixed
@arkjedrz
arkjedrz force-pushed the arkjedrz_global-logger branch from b6b66e3 to 48ad554 Compare November 2, 2026 14:46
github-advanced-security[bot]
github-advanced-security Bot found potential problems Nov 2, 2026
View reviewed changes
Comment thread score/kvs/kvs.cpp Fixed
Comment thread score/kvs/kvs.cpp Fixed
arkjedrz and others added 2 commits November 2, 2026 19:52
@arkjedrz
kvs: global logger and enhanced logs
1354dc8 
- Add a global logger, accessible through `internal/logger.h` (`GetLogger()`).
- Remove `logger_` field from `Kvs`.
- Move functions no longer using any field to anonymous namespace.
- Provide more obvious logs from `Kvs`.
@arkjedrz @claude
kvs: fix MISRA findings in the global logger
5deec45 
Align the logger code with the MISRA C++:2023 fixes on main.

- Declare kLogContext const instead of constexpr (Rule 4.1.2).
- Mark the two RemoveIfExists results discarded through score::cpp::ignore in WriteTempFile with the kvs-bool-ref-binding deviation (Rule 7.0.1).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@arkjedrz
arkjedrz force-pushed the arkjedrz_global-logger branch from 48ad554 to 5deec45 Compare November 2, 2026 19:10

This branch is waiting to be deployed

1 waiting (outdated) deployment
workflow-approval — b6b66e37 Waiting Oct 30, 2026 by arkjedrz via qnx-build (score-qnx-aarch64) / approval #1658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinodreddy-g vinodreddy-g Awaiting requested review from vinodreddy-g vinodreddy-g is a code owner
@PandaeDo PandaeDo Awaiting requested review from PandaeDo PandaeDo is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@umaucher umaucher Awaiting requested review from umaucher umaucher is a code owner
2 more reviewers
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
@karolnowak karolnowak karolnowak approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@arkjedrz arkjedrz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Global logger object

3 participants

@arkjedrz @github-advanced-security @karolnowak