Skip to content

build: drop root check aliases and call //tools targets - #596

Open
arkjedrz wants to merge 1 commit into
mainfrom
arkjedrz_tooling-04-root-labels
Open

arkjedrz wants to merge 1 commit into
mainfrom
arkjedrz_tooling-04-root-labels

Conversation

@arkjedrz

Copy link
Copy Markdown
Contributor
  • Remove the root aliases copyright.check, copyright.fix, format.fix, license-check and the root format.check test_suite.
  • on-pr.yml passes format-target and copyright-target with the //tools labels, as baselibs does.
  • license_check.yml runs //tools:license-check.
  • Drop the //:pkg default visibility in tools/BUILD. Only the root test_suite needed it.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //tools:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Starting local Bazel server (8.8.2) and connecting to it...
INFO: Invocation ID: 4f7d2ca7-6557-42c1-a857-637569ab4b5e
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: tools
Loading: 2 packages loaded
    currently loading: tools
Loading: 2 packages loaded
    currently loading: tools
Loading: 2 packages loaded
    currently loading: tools
Loading: 2 packages loaded
    currently loading: tools
Loading: 2 packages loaded
    currently loading: tools
Analyzing: target //tools:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //tools:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //tools:license-check (93 packages loaded, 14 targets configured)

Analyzing: target //tools:license-check (98 packages loaded, 14 targets configured)

Analyzing: target //tools:license-check (99 packages loaded, 14 targets configured)

Analyzing: target //tools:license-check (99 packages loaded, 14 targets configured)

Analyzing: target //tools:license-check (155 packages loaded, 3722 targets configured)

Analyzing: target //tools:license-check (201 packages loaded, 5136 targets configured)

Analyzing: target //tools:license-check (207 packages loaded, 11661 targets configured)

Analyzing: target //tools:license-check (207 packages loaded, 11661 targets configured)

Analyzing: target //tools:license-check (208 packages loaded, 11661 targets configured)

Analyzing: target //tools:license-check (211 packages loaded, 17650 targets configured)

Analyzing: target //tools:license-check (211 packages loaded, 17650 targets configured)

Analyzing: target //tools:license-check (212 packages loaded, 17774 targets configured)

Analyzing: target //tools:license-check (212 packages loaded, 17774 targets configured)

Analyzing: target //tools:license-check (212 packages loaded, 17774 targets configured)

INFO: Analyzed target //tools:license-check (213 packages loaded, 17902 targets configured).

INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 50 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/tools/formatted.txt
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
INFO: Found 1 target...
Target //tools:license.check.license_check up-to-date:
  bazel-bin/tools/license.check.license_check
  bazel-bin/tools/license.check.license_check.jar
INFO: Elapsed time: 63.509s, Critical Path: 2.07s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/tools/license.check.license_check tools/formatted.txt <args omitted>
[main] INFO Querying Eclipse Foundation for license data for 42 items.
[main] INFO Found 32 items.
[main] INFO Querying ClearlyDefined for license data for 10 items.
[main] INFO Found 10 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO crate/cratesio/-/lazy_static/1.5.1
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.

@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-596: https://eclipse-score.github.io/persistency/pr-596/

@arkjedrz
arkjedrz force-pushed the arkjedrz_tooling-04-root-labels branch 2 times, most recently from d24cb64 to 03183b6 Compare October 28, 2026 13:03
- Remove the root aliases copyright.check, copyright.fix, format.fix,
  license-check and the root format.check test_suite.
- on-pr.yml passes format-target and copyright-target with the //tools
  labels, as baselibs does.
- license_check.yml runs //tools:license-check.
- Drop the //:__pkg__ default visibility in tools/BUILD. Only the root
  test_suite needed it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@arkjedrz
arkjedrz force-pushed the arkjedrz_tooling-04-root-labels branch from 03183b6 to 95471e0 Compare November 2, 2026 14:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant