Removing Config Adapter - #455
Merged
Merged
Conversation
MaciejKaszynski
requested a deployment
to
workflow-approval
August 12, 2026 08:17 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 12, 2026 08:17 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 13, 2026 07:13 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 13, 2026 07:13 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
MaciejKaszynski
force-pushed
the
new-config
branch
from
August 13, 2026 09:15
48210c0 to
84721b9
Compare
MaciejKaszynski
requested a deployment
to
workflow-approval
August 13, 2026 09:15 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 13, 2026 09:15 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 13, 2026 14:26 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 13, 2026 14:26 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 14, 2026 08:24 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 14, 2026 08:24 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 14, 2026 08:28 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 14, 2026 08:28 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 14, 2026 10:51 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 14, 2026 10:51 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 14, 2026 14:24 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 14, 2026 14:24 — with
GitHub Actions
Waiting
MaciejKaszynski
marked this pull request as ready for review
August 14, 2026 14:24
MaciejKaszynski
requested review from
FScholPer,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
August 14, 2026 14:24
|
The created documentation from the pull request is available at: docu-html |
MaciejKaszynski
force-pushed
the
new-config
branch
from
August 19, 2026 09:56
8b4f3b1 to
7f49709
Compare
WilliamRoebuck
approved these changes
Aug 19, 2026
NicolasFussberger
previously approved these changes
Aug 19, 2026
NicolasFussberger
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #420
Currently we have a lot of code to bridge the old config and new. This PR removes the bridge and changes. Process Group Manager, Graph and Alive Monitor to use the new config.
This also partially addresses some multi-og code from #413. However our IPC still has a field for the pg_name and there is still a bunch of references to it in comments and method names.
This also creates a temporary
CreateDependencyGraphfunction that takes the config and creates aDependencyGraphfrom it. This is intentionally left as not polished and un covered with UTs as it shall be more or less removed in #463.Another point to address is that the AliveMonitor copies its config as the shape of the config doesn't fit the current implementation. This will be addressed in #477.