Skip to content

crypto: refactor integration tests for QNX ITF execution - #166

Open
OliverHeilwagen wants to merge 4 commits into
eclipse-score:mainfrom
etas-contrib:refactor_integration_test
Open

crypto: refactor integration tests for QNX ITF execution#166
OliverHeilwagen wants to merge 4 commits into
eclipse-score:mainfrom
etas-contrib:refactor_integration_test

Conversation

@OliverHeilwagen

Copy link
Copy Markdown
Contributor
  • Add the shared ITF integration-test macro and process-runner utility.
  • Rework integration tests and C++ examples for Docker and QEMU execution.
  • Add the x86_64 QNX QEMU environment, IFS configuration, and required tools.
  • Update Bazel, module, devcontainer, CI, and README configuration for QNX ITF.
  • Use an atomic in-use flag for concurrent PKCS#11 session-key handling.

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 120a2c92-4717-4984-9bdd-5413ffe9273c
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'score_logging+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-/Q5+YfLkbMpz5PfvOkNS7qA3ehzth4emFhTcsk4q3zQ="
DEBUG: Repository score_logging+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
DEBUG: Rule 'abseil-cpp+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-m3oGQwXp/ZTRJP+mzDWFkutCtdpYj7TgfQklSqQAhts="
DEBUG: Repository abseil-cpp+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
DEBUG: Rule 'score_baselibs_rust+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-4kzcXcvGi9xBEEnrPOiSEvteITZMPKmK3MNgJXQIGtY="
DEBUG: Repository score_baselibs_rust+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
DEBUG: Rule 'protobuf+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-w6Cp7OiTLjHDtzbi2xixxC5wcM2biBOIsm0BqnHiTKI="
DEBUG: Repository protobuf+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
DEBUG: Rule 'grpc+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-CvN7gAlTEwtHwHW1ZoPuYL3D7aPDf8YAQZP1tWl1ggQ="
DEBUG: Repository grpc+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
WARNING: For repository 'score_docs_as_code', the root module requires module version score_docs_as_code@6.0.0, but got score_docs_as_code@8.0.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_devcontainer', the root module requires module version score_devcontainer@1.10.0, but got score_devcontainer@1.11.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/inc_security_crypto/inc_security_crypto/BUILD
INFO: Elapsed time: 11.791s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions

Copy link
Copy Markdown
Contributor

The created documentation from the pull request is available at: docu-html

@ChansAlive ChansAlive left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial quick review comments

Comment thread score/crypto/src/daemon/provider/pkcs11/operations/mac/pkcs11_mac_handler.cpp Outdated
Comment thread score/crypto/src/daemon/provider/pkcs11/operations/mac/pkcs11_mac_handler.cpp Outdated
Comment thread score/tests/integration_tests/integration_test.py Outdated
Comment thread score/tests/integration_tests/integration_test.py Outdated
Comment thread score/tests/integration_tests/score_api_hash_example.cpp
Comment thread .devcontainer/Dockerfile Outdated
Comment thread .devcontainer/Dockerfile
Comment thread .pre-commit-config.yaml
- id: generate-compile-commands
name: bazel-compile-commands (for clang-tidy)
entry: bazel-compile-commands
entry: bazel-compile-commands --compiler /usr/bin/clang -R "-fno-canonical-system-headers=" //...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the default created bazel-compile-commands external headers are not found by clang-tidy.

Note:
clang-tidy warnings slightly differ to clangd vscode language server especially in [misc-include-cleaner,-warnings-as-errors]

@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-166: https://eclipse-score.github.io/inc_security_crypto/pr-166/

- Add the shared ITF integration-test macro and process-runner utility.
- Rework integration tests and C++ examples for Docker and QEMU execution.
- Add the x86_64 QNX QEMU environment, IFS configuration, and required tools.
- Update Bazel, module, devcontainer, CI, and README configuration for QNX ITF.
- Use an atomic in-use flag for concurrent PKCS#11 session-key handling.
- Update ResolvedKey handling with RAII-based PKCS#11 key ownership and
  contention management.
- Fix clang-tidy warnings across backend, configuration, and integration-test
  code.
- Add dedicated Linux test matrix for default, PKCS#11, and OpenSSL
  backends, including distinct test-result uploads.
- Simplify integration-test process execution and support target-specific
  deployment paths.
- Add  setup via �[1mCreated '/workspaces/inc_security_crypto/.venv_test', to activate run:�(B�[m
  source /workspaces/inc_security_crypto/.venv_test/bin/activate.
- Fix Python typing and linter warnings.
@OliverHeilwagen
OliverHeilwagen force-pushed the refactor_integration_test branch from 81b6a0a to a2005d4 Compare August 26, 2026 13:29
@OliverHeilwagen
OliverHeilwagen deployed to workflow-approval August 26, 2026 13:29 — with GitHub Actions Active
@OliverHeilwagen
OliverHeilwagen deployed to workflow-approval August 26, 2026 13:29 — with GitHub Actions Active
@RolandJentschETAS
RolandJentschETAS deployed to workflow-approval August 27, 2026 11:16 — with GitHub Actions Active
@RolandJentschETAS
RolandJentschETAS deployed to workflow-approval August 27, 2026 11:16 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants