Skip to content

Enable devcontainer in Workflows#411

Open
MaximilianSoerenPollak wants to merge 1 commit intoeclipse-score:mainfrom
MaximilianSoerenPollak:MSP_add_pre_commit
Open

Enable devcontainer in Workflows#411
MaximilianSoerenPollak wants to merge 1 commit intoeclipse-score:mainfrom
MaximilianSoerenPollak:MSP_add_pre_commit

Conversation

@MaximilianSoerenPollak
Copy link
Copy Markdown
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak commented Feb 23, 2026

Benefits:

  • yamlfmt, ruff, basedpyright, actionlint, shellcheck, buildifier versions dictated centrally by devcontainer
  • centralized "open in devcontainer and you are good to go", no custom commands like install bazel and run ide_support
  • same baseline for debugging. An issue is reported and you can get to the same baseline 'faster' than before

Drawbacks:

  • increase in startup time of dev environment
  • increase in CI runtime
  • pre-commit will not work without devcontainer

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 23, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
2026/04/13 09:23:47 Downloading https://releases.bazel.build/8.3.0/release/bazel-8.3.0-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 6e4a51cf-2602-4332-a4c7-d4fdf791306d
Computing main repo mapping: 
ERROR: Error computing the main repository mapping: Missing checksum for registry file https://raw.githubusercontent.com/eclipse-score/bazel_registry/main/modules/score_tooling/1.1.2/MODULE.bazel not permitted with --lockfile_mode=error. Please run `bazel mod deps --lockfile_mode=update` to update your lockfile.

@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

{
"name": "eclipse-s-core",
"image": "ghcr.io/eclipse-score/devcontainer:1.0.0",
"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this and tell me if you stell need PIPX_BIN_DIR to execute pre-commit?

Suggested change
"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
"postCreateCommand": "echo \"export PATH=$PIPX_BIN_DIR:$PATH\" | sudo tee /etc/bash_completion.d/add_pipx_to_path",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works in conjunction with devcontainer/cli. If this works I can add this to the image.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I found a solution, which works in /etc/profile.d/. This took me way too long time

Suggested change
"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
"image": "ghcr.io/eclipse-score/devcontainer:v1.2.0",
"postCreateCommand": "echo \"export PATH=$PIPX_BIN_DIR:$PATH\" | sudo tee /etc/profile.d/add_pipx_to_path.sh",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be taken care of with eclipse-score/devcontainer#98

Comment thread .pre-commit-config.yaml Outdated
@MaximilianSoerenPollak MaximilianSoerenPollak marked this pull request as draft February 25, 2026 09:12
@MaximilianSoerenPollak
Copy link
Copy Markdown
Contributor Author

Converted to Draft, as currently unsure if this PR is in the right direction of the Repo.

@AlexanderLanin
Copy link
Copy Markdown
Member

@MaximilianSoerenPollak have fun merging/rebasing. Looks like there are some conflicts.

run: bash scripts/run-linters.sh
cacheFrom: ghcr.io/eclipse-score/devcontainer
push: never
runCmd: ${PIPX_BIN_DIR}/pre-commit run -a
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current main tag PIPX_BIN_DIR is now part of $PATH

Suggested change
runCmd: ${PIPX_BIN_DIR}/pre-commit run -a
runCmd: pre-commit run -a

Comment thread .github/workflows/test.yml Outdated
Comment on lines -33 to -34
- name: Setup Bazel with cache
uses: bazel-contrib/setup-bazel@0.15.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep an eye on build times and if we can use a cache with the devcontainer

export PYTHONUNBUFFERED="1"
export CONSUMER="${{ matrix.consumer }}"
export PYTHONPATH=.
uv run pytest -s -v src/tests/ \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest is preinstalled in the devcontainer and should be accessible without uv. Maybe uv just runs what is already there

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes pytest is there, but the packages this test needs arent'.

So i installe eveyrthing via uv then running it

@MaximilianSoerenPollak MaximilianSoerenPollak marked this pull request as ready for review February 25, 2026 14:51
@MaximilianSoerenPollak MaximilianSoerenPollak changed the title Add pre-commit config & upgrade devcontainer Enable devcontainer in Workflows Feb 25, 2026
@MaximilianSoerenPollak
Copy link
Copy Markdown
Contributor Author

I honestly do not know why some of the changes it says they are new here ?

@github-actions
Copy link
Copy Markdown

Thanks for the pull request. This thread has been quiet for 30 days, so we are marking it as stale for now. Please take a quick look and let us know whether it is still up to date, still relevant, needs review, or is ready to merge. Any new activity will remove the stale label automatically. If nothing changes in the next 10 days, we will close it to keep the backlog current.

@github-actions github-actions bot added the stale label Mar 31, 2026
@github-actions
Copy link
Copy Markdown

We are closing this pull request because it stayed stale for 10 more days without any new activity. If this is still relevant, please reopen it or open a fresh pull request when you are ready, and we will pick it up from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants