Add downstream coverage workflow tests - #22
Draft
AlexanderLanin wants to merge 7 commits into
Draft
AlexanderLanin wants to merge 7 commits into
AlexanderLanin wants to merge 7 commits into
Conversation
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
Contributor
|
Documentation preview for this pull request is available at: |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Coverage artifacts are lost on gate and empty-report failures, limiting diagnosis of the regressions these tests detect.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds CI integration tests that validate score_coverage against the baselibs and lifecycle downstream workflows.
Changes:
- Adds downstream coverage tests and shared workspace/report helpers.
- Adds dedicated Bazel targets and required development dependency.
- Adds a cached matrix workflow with summaries and downloadable artifacts.
| File | Description |
|---|---|
tools/downstream_tests/test_lifecycle.py |
Tests lifecycle coverage with its 66% gate. |
tools/downstream_tests/test_baselibs.py |
Tests baselibs coverage with required exclusions. |
tools/downstream_tests/BUILD |
Defines separate downstream pytest targets. |
tools/downstream_tests/_consumer_workspace.py |
Clones consumers, runs Bazel, and retains reports. |
MODULE.bazel |
Adds the score_tools development dependency. |
MODULE.bazel.lock |
Locks the new dependency metadata. |
.github/workflows/tests.yml |
Excludes integration tests from the unit-test job. |
.github/workflows/downstream_tests.yml |
Runs downstream tests and uploads their results. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Validate
score_coverageagainst the real coverage workflows used by direct downstream consumers, so integration regressions are caught where the tool is used. Make the resulting coverage data visible and downloadable from CI.Changes
baselibsandlifecyclecoverage workflows, with a local override to this checkout.main. Main runs seed per-consumer Bazel caches for later PRs.vajson_serialize_testfrom this coverage run; its compact-JSON expectations conflict with the consumer's current pretty-print default.baselibsandlifecycle; legacyscore_toolingconsumers are unchanged.