Repository navigation
Conversation
The Qorix version of this training had its first run in October 2026. The
participants' continuous improvement feedback applies here too:
- #R4 conflicted with main before task 5.3: participants picked its id
instruction line as the self-found typo in 1.3, or aligned it in their #R1
fix. 1.2-1.3 and 4.1 now say to leave the attention blocks alone until
stage 5; 5.3 says what to do if #R4 conflicts anyway. SOLUTIONS.md records
the trap.
- Merging the fix first lets GitHub mark the prepared pull request as
merged, and a merged pull request cannot be closed. 4.1, 4.2 and 6.1 now
say to close it first.
- Rule 3 was supported by nothing. A commit message template, .gitmessage,
set up in "Set up your copy", asks for the reason and a Checked: line.
- What valid means on a branch was unclear. TRAINING.md states it once, as
the solution key already reads it (#R2 defect 5, #R5) and as the S-CORE
requirements concept says it for requirements.
- 1.1 and 2.2-2.4 name the git commands and say to pull main before building
it; "When something breaks" points to Pro Git for rebasing.
- 3.1 shows the :need: syntax, and 3.1 and 3.2 say no need is created.
- 5.4 gives the rule for a predecessor's text: every statement needs a
source.
Checked: every text replacement matched exactly once; render_issue from
training/setup.py renders all 15 task files with no {{...}} left;
pre-commit run on the changed files passes.
Assisted-by: Claude Code (claude-opus-5-5)
PandaeDo
requested review from
RolandJentschETAS,
aschemmel-tech,
masc2023 and
pahmann
as code owners
November 3, 2026 15:57
masc2023
reviewed
Nov 3, 2026
| Re-checked 2026-10-29 on `4dc60d8` with `main` + r1, r2, r3, r5-security, then r4: the same | ||
| three conflicts. | ||
|
|
||
| What the simulations missed, found in the first run of the Qorix version of this training |
There was a problem hiding this comment.
Qorix is part here, so should it be not contributor neutral here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Qorix version of this training had its first run with five participants in October 2026. Their continuous improvement feedback applies here too, so this brings the same fixes upstream.
mainbefore task 5.3. Three of five participants had picked itsidinstruction line as the self-found typo in 1.3, or aligned it in their #R1 fix.. attention::blocks alone until stage 5. 5.3: what to do if #R4 conflicts anyway.SOLUTIONS.mdrecords the trap.gitmessagecommit template, set up in "Set up your copy". No enforcing hookvalidmeans on a branch is unclear (templates: "set to valid"; documentation guideline: valid once reviewed)TRAINING.mdstates it once: the status takes effect when the pull request is approved and merged. This is the reading the solution key already uses, and the one the requirements concept states for requirementsmainmainbefore building it; Pro Git pointer for rebasing:need:syntax; 3.1 and 3.2 say no need is createdChecked: every text replacement matched exactly once.
render_issuefromtraining/setup.pyrenders all 15 task files with no{{…}}left.pre-commit runon the changed files passes.Small change (34 lines added, 12 removed), so no IP review is needed.
.gitmessagecarries the AI disclosure header like the other generated files.🤖 Generated with Claude Code. Assisted-by: Claude Code (claude-opus-5-5); reviewed by the author.