Repository navigation
Fix MISRA C++ RULE-7-0-1 conversions from bool - #1440
Merged
Merged
Conversation
- TransactionLogSlot: convert bool to the stored uint8_t via an explicit conditional instead of static_cast<uint8_t>(bool). - message_passing LogConvert: add a dedicated bool overload that logs 0/1 (unchanged output) instead of casting bool through the unsigned integer overload. - ReadMaskSet: the bitmask operator& already yields bool, so return it directly instead of casting to the underlying type and comparing. No functional change. The remaining alerts for this rule are bool-to- bool-reference bindings, already fixed in codeql-coding-standards (github/codeql-coding-standards#1176) and expected in 2.63.0, and reference bindings in structured bindings that are query false positives. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
castler
marked this pull request as ready for review
October 26, 2026 10:32
castler
requested review from
LittleHuba,
bemerybmw,
crimson11,
hoe-jo and
limdor
as code owners
October 26, 2026 10:32
castler
enabled auto-merge
October 26, 2026 10:32
crimson11
approved these changes
Oct 26, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in COM - Communication FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the genuine no-conversion-from-bool findings (TransactionLogSlot, message_passing LogConvert, ReadMaskSet). Behavior unchanged; affected tests pass. Remaining alerts are bool-to-reference FPs fixed upstream in github/codeql-coding-standards#1176 (2.63.0) or structured-binding FPs.