Revert "Make completion proposal calculation test time-independent #906"

[fedejeanne]

This reverts commit 56f9d17 which caused #3880

Fixes #3880

[vogella]

I'm also looking into that. Here is my check script to see if the test is stable:

#!/bin/bash
# Runs CompletionTest 50 times to verify test stability
# Stops immediately on first failure and prints the test output
# Usage: ./run-completion-tests-50x.sh

for i in $(seq 1 50); do
    echo "=== Run $i/50 ==="
    OUTPUT=$(mvn clean verify -pl tests/org.eclipse.ui.genericeditor.tests \
        -Pbuild-individual-bundles \
        -Dtest=CompletionTest 2>&1)

    if [ $? -ne 0 ]; then
        echo "FAILED on run $i/50"
        echo ""
        echo "$OUTPUT" | grep -A 20 -E "(Tests run:.*Failures:|FAILURE|AssertionError|AssertionError|java\.lang\.)"
        echo ""
        echo "Full log saved to /tmp/completion-test-failure.log"
        echo "$OUTPUT" > /tmp/completion-test-failure.log
        exit 1
    fi
    echo "  -> PASS ($i/50)"
done

echo ""
echo "All 50 runs passed."

[vogella]

I think I have a fix, please do this merge this revert. It just takes a bit of time to run the tests 50 times, currently at 7/50 successful runs.

[fedejeanne]

@vogella I drafted it. If the fix doesn't work, I can undraft and merge at EOD. Please let me know :-)

And thank you very much for looking into it!

[github-actions]

Test Results

   852 files  ±0     852 suites  ±0   52m 29s ⏱️ - 5m 8s
 7 894 tests ±0   7 651 ✅ +2  243 💤 ±0  0 ❌  - 2 
20 184 runs  ±0  19 529 ✅ +2  655 💤 ±0  0 ❌  - 2 

Results for commit 6dba2e0. ± Comparison against base commit 357b87c.

[fedejeanne]

Unnecessary due to #3887