fix: Properly wait for pending document setups#1554
Merged
Conversation
Contributor
Author
|
A small fix which I extracted from #1546 which can be merged independently. |
rubenporras
requested changes
Jun 29, 2026
rubenporras
left a comment
rubenporras
left a comment
Contributor
There was a problem hiding this comment.
Would you mind changing the comment as I suggest or otherwise? It looks to me from the class comment that this class in not "test" only.
The CompletableFuture that we want to wait for during testing is only added to `PENDING_CONNECTIONS` after a delay of one second. So it's possible, that `waitForAll` has already returned but there are still pending document setups
FlorianKroiss
force-pushed
the
fix-setup-wait
branch
from
4199b31 to
3ec877e
Compare
FlorianKroiss
changed the title
rubenporras
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CompletableFutures that we want to wait for during testing are only added to
PENDING_CONNECTIONSafter a delay of one second. So it's possible, thatwaitForAllhas already returned but there are still pending document setups