Repository navigation
build: skip javadoc publication for snapshots - #497
Merged
Merged
Conversation
wolf4ood
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
When the project version ends with
-SNAPSHOT,MavenPublicationConventionnow configures the vanniktech publication without a javadoc jar (configureBasedOnAppliedPlugins(true, false)→JavadocJar.None). Release publications are unchanged: they still get the javadoc jar, which Maven Central requires.Why it does that
Since 2026-11-12, snapshot publication has been failing with
429 Too Many Requestsfromcentral.sonatype.com/repository/maven-snapshots(e.g. Connector and IdentityHubtrigger_snapshotruns). A full Connector snapshot run publishes ~196 modules sequentially, with every file uploaded together with its.ascsignature and md5/sha1/sha256/sha512 checksums.Maven Central doesn't validate snapshots ("As with the legacy OSSRH
-SNAPSHOTpublishing, no validation is performed", docs), so the javadoc jar isn't needed there. Dropping it removes roughly 8–10 requests per module (the jar, its signature and their checksums), on the order of 1.5–2k fewer requests per Connector snapshot run. It also skips the javadoc generation, which saves build time.Further notes
configureBasedOnAppliedPluginsexplicitly. The vanniktech plugin would otherwise call it itself after the project is evaluated; that call does nothing once a platform is already configured.--include-build, usingpublishToMavenLocal --dry-runon:core:common:junit-base:1.0.0-SNAPSHOT:plainJavadocJaris no longer part of the task graph;sourcesJarand test fixtures are still there.1.0.0:plainJavadocJaris still executed.Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.