Repository navigation
fix: add servesDataset to the DataService context - #286
Open
SimonStier wants to merge 1 commit into
Open
SimonStier wants to merge 1 commit into
SimonStier wants to merge 1 commit into
Conversation
- the term was absent, so a schema-valid DataService carrying it lost the whole subtree on expansion and did not compact back to itself - declared with @container @set, matching service, catalog, dataset and distribution, so a single-item array does not compact to a bare object - no @type @id, since the items are Dataset node objects Signed-off-by: Simon Stier <simon.stier@isc.fraunhofer.de>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds
servesDatasetto theDataServicescoped context incontext/dspace.jsonld:The term was absent, so a schema-valid
DataServicepopulating it lost the whole subtree onexpansion and did not compact back to itself.
dataset-schema.jsondeclares the property asarray[ Dataset ]and the published type table lists it.@container: "@set"matches howservice,catalog,datasetanddistributionare declared,and keeps a single-item array from compacting to a bare object, which would fail the schema.
@type: "@id", since the items areDatasetnode objects and link without coercion.Additive: every message that validates today continues to validate and compacts unchanged.
Further notes
No shipped example populates
servesDataset, so no example or test fixture changes here. Verifiedwith a JSON-LD processor against the patched context: the property expands to
dcat:servesDatasetand compacts back identically, preserving the array.
Linked Issue(s)
Closes #277