fix: Change CI failure level from warn to error#3063
Merged
gtrivedi88 merged 1 commit intoeclipse-che:mainfrom Apr 13, 2026
Merged
fix: Change CI failure level from warn to error#3063gtrivedi88 merged 1 commit intoeclipse-che:mainfrom
gtrivedi88 merged 1 commit intoeclipse-che:mainfrom
Conversation
The failure_level: warn setting causes CI to fail on harmless warnings
from unresolved curly braces in shell/jsonpath expressions inside source
blocks (e.g., {home}, {end}, {patch}, {ovsx_pod_name}). The Antora
assembler produces a monolithic AsciiDoc file where these literal curly
braces get misinterpreted as AsciiDoc attributes.
Changing to failure_level: error still catches real build errors while
allowing these harmless warnings to pass. This unblocks PRs that are
currently failing due to pre-existing warnings on main.
gtrivedi88
requested review from
a team,
deerskindoll and
mkuznyetsov
as code owners
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
|
🎊 Navigate the preview: https://69dcf4b135f1ea54b61197eb--eclipse-che-docs-pr.netlify.app 🎊 |
tolusha
approved these changes
Apr 13, 2026
gtrivedi88
added a commit
to gtrivedi88/che-docs
that referenced
this pull request
Apr 13, 2026
PR eclipse-che#3063 updated the playbook setting but both workflow files pass --log-failure-level=warn on the CLI, which overrides the playbook. This causes CI to fail on pre-existing asciidoctor errors from the Antora assembler generating invalid part structures in the monolithic output file. Changing the CLI flag to error aligns with the playbook setting from PR eclipse-che#3063 and allows the build to complete. Signed-off-by: Grishma Trivedi <gtrivedi@redhat.com>
2 tasks
gtrivedi88
added a commit
that referenced
this pull request
Apr 13, 2026
…3064) PR #3063 updated the playbook setting but both workflow files pass --log-failure-level=warn on the CLI, which overrides the playbook. This causes CI to fail on pre-existing asciidoctor errors from the Antora assembler generating invalid part structures in the monolithic output file. Changing the CLI flag to error aligns with the playbook setting from PR #3063 and allows the build to complete. Signed-off-by: Grishma Trivedi <gtrivedi@redhat.com>
gtrivedi88
added a commit
to gtrivedi88/che-docs
that referenced
this pull request
Apr 13, 2026
This is the last of four locations that had --log-failure-level=warn: 1. antora-playbook-for-development.yml (fixed in eclipse-che#3063) 2. .github/workflows/build-and-validate-on-pr.yaml (fixed in eclipse-che#3064) 3. .github/workflows/build-and-validate-on-push.yaml (fixed in eclipse-che#3064) 4. tools/build.sh (this PR) This script is called by tools/build-and-verify-container.sh, which powers the "Build and verify container" CI check. Signed-off-by: Grishma Trivedi <gtrivedi@redhat.com>
tolusha
pushed a commit
that referenced
this pull request
Apr 13, 2026
…#3065) This is the last of four locations that had --log-failure-level=warn: 1. antora-playbook-for-development.yml (fixed in #3063) 2. .github/workflows/build-and-validate-on-pr.yaml (fixed in #3064) 3. .github/workflows/build-and-validate-on-push.yaml (fixed in #3064) 4. tools/build.sh (this PR) This script is called by tools/build-and-verify-container.sh, which powers the "Build and verify container" CI check. Signed-off-by: Grishma Trivedi <gtrivedi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
Changes
failure_levelfromwarntoerrorinantora-playbook-for-development.yml.The
warnsetting causes both CI checks ("Build and validate pull request" and "Build and verify container") to fail on ~40 harmless warnings from unresolved curly braces in shell/jsonpath expressions inside source blocks (e.g.,{home},{end},{patch},{ovsx_pod_name}). The Antora assembler produces a monolithic AsciiDoc file where these literal curly braces get misinterpreted as AsciiDoc attributes.Changing to
errorstill catches real build errors while allowing these harmless warnings to pass.What issues does this pull request fix or reference?
Unblocks PR #3060 and any other PR currently failing due to pre-existing warnings on
main.Specify the version of the product this pull request applies to
main
Pull Request checklist
Validate language on files added or modifiedstep reports no vale warnings.