Add CoralscapesV2 segmentation models - #36
Merged
Merged
Conversation
HuguesSib
previously approved these changes
Sep 16, 2026
HuguesSib
left a comment
HuguesSib
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
Just one thing to note for a follow-up, can we add a coralscapesv2-segformer-b5-95 scenario to the e2e test matrix? We're switching the default model but the CI still only tests the old SegFormers. Tagging @evanjt here.
Also one thing I realized would be to clean up model_zoo.yaml that is not read anywhere.
HuguesSib
approved these changes
Sep 22, 2026
evanjt
approved these changes
Sep 22, 2026
evanjt
reviewed
Sep 22, 2026
evanjt
left a comment
evanjt
left a comment
Contributor
There was a problem hiding this comment.
Having the new classes placed in the repo twice is not ideal, since we need the configs in code (and not in /config) to package with the library. I would suggest that we have just one place it sits in resources/configs. We can decide on this later though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new models from https://josauder.github.io/coralscapesv2
V2 extends the segmentation to 95 semantic classes, but also provides models for the legacy 39 classes. The default is now that we load the classes/colors config that corresponds to the models. This can be overridden by the user using the CLI flag