Skip to content

Python: validate local shell approval binding - #16

Closed
eavanvalkenburg wants to merge 2 commits into
mainfrom
workflow-input-fix
Closed

eavanvalkenburg wants to merge 2 commits into
mainfrom
workflow-input-fix

Conversation

@eavanvalkenburg

Copy link
Copy Markdown
Owner

Motivation & Context

Add end-to-end coverage that verifies a local shell invocation supplied through a labeled variable remains bound to the command reviewed during approval and cannot be replayed across turns or sessions.

Description & Review Guide

  • What are the major changes? Added deterministic LocalShellTool regression coverage for exact approved argv, changed variable resolution, substituted approval fields, and replay isolation.
  • What is the impact of these changes? Test-only coverage; runtime behavior and public APIs are unchanged. The LocalShellTool suite, focused core approval/security regressions, tools syntax checks, and tools test typing pass.
  • What do you want reviewers to focus on? Confirm the scenarios exercise the full function-invocation, approval, variable-expansion, policy, and subprocess boundary without relying on a real shell process.

Related Issue

N/A - no high-confidence overlapping open issue was found.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and the title prefix in sync automatically.

dependabot Bot and others added 2 commits September 10, 2026 11:20
…8213)

* Build(deps): bump astral-sh/setup-uv from 9.0.0 to 10.0.1

Bumps [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) from 9.0.0 to 10.0.1.
- [Release notes](https://github.com/astral-sh/setup-uv/releases)
- [Commits](astral-sh/setup-uv@v9.0.0...20cfd1b)

---
updated-dependencies:
- dependency-name: astral-sh/setup-uv
  dependency-version: 10.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Change cache setting to auto in devflow PR review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Change cache enable option to auto in workflow

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@eavanvalkenburg

Copy link
Copy Markdown
Owner Author

Closing because this change must target the upstream repository.

This branch had an error being deployed

1 failed deployment
github-app-auth — 94ff9d9b Deployed Sep 10, 2026 by eavanvalkenburg via team_check #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant