prettify the summary#356
Open
rozyczko wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #356 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 40 40
Lines 2706 2742 +36
=======================================
- Misses 2706 2742 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the summary generation in the
easyreflectometrymodule by improving formatting, user interface consistency, and the display of fit statistics. The main changes include restoring and computing the goodness-of-fit value in the HTML summary, introducing utility functions for formatting errors and truncating names with tooltips, and ensuring experiment names are displayed concisely with tooltips for long names.User interface and formatting improvements:
_format_errorfunction to ensure parameter errors are formatted consistently with the Analysis table, matching the JavaScript logic in the UI. (src/easyreflectometry/summary/summary.py_truncate_namefunction to display long experiment names in a truncated form with tooltips, improving readability and UX in the summary. (src/easyreflectometry/summary/summary.py)Goodness-of-fit reporting:
_compute_goodness_of_fitto calculate and format the value, or display 'N/A' if unavailable. (src/easyreflectometry/summary/html_templates.pyCodebase improvements:
escapeandquotefrom the standard library to support HTML escaping and URL encoding in tooltips. (src/easyreflectometry/summary/summary.py