Repository navigation
chore: Add extension host test GitHub Action annotations - #345
Draft
X-Guardian wants to merge 1 commit into
Draft
X-Guardian wants to merge 1 commit into
X-Guardian wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github-actionsreporter whenGITHUB_ACTIONSis set. That is the spec reporter plus the annotations and job summary, and it needs no new dependency. Elsewhere it keeps the spec reporter.out-test, which are not in the repository. The runner now rewrites those frames to theirtests/extension-host/**/*.tslines through the.js.mapfiles, using Node'smodule.SourceMap, before the reporter reads them. Failure stacks in the spec output name the.tslines too, locally as well as in CI.GITHUB_ACTIONSandGITHUB_STEP_SUMMARY, and both reach the extension host throughnpm run test:extension-host.Change Type
Context
User-facing impact
GitLab scope
Affected areas
Validation
Local checks
npm run compilenpm testor targeted testsManual test notes
1 === 2and rannpm run test:extension-hostwithGITHUB_ACTIONS=trueandGITHUB_STEP_SUMMARYset. All 22 real tests passed. The reporter printed::error file=tests/extension-host/suite/zzAnnotation.test.ts,line=5,col=12::Expected values to be strictly equal…, which is the assertion's line, and wrote22 passingand1 failingto the summary file.GITHUB_ACTIONS, the output is the spec reporter's with no::errorlines, and the failure's stack nameszzAnnotation.test.ts:5:12.Breaking Changes
Risk and Rollback
Release Notes Draft
Checklist