Repository navigation
ci(e2e): bring back the iOS and Android jobs - #4
Merged
Merged
Conversation
Boots the runner's own iPhone 17 Pro instead of creating a simulator, which spent over 7 minutes on its first boot, and gives the iOS job 90 minutes since the Release build alone takes about 35.
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/e2e.yml">
<violation number="1" location=".github/workflows/e2e.yml:88">
P2: This unconditionally boots the selected simulator, so the job fails if the runner image already has its iPhone 17 Pro booted. Replace it with `xcrun simctl bootstatus "$UDID" -b`, which handles both shutdown and booted states while waiting for readiness.</violation>
</file>
Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.
View guided diff | Turn on auto-fix | Re-trigger cubic
| xcrun simctl list runtimes | ||
| exit 1 | ||
| fi | ||
| xcrun simctl boot "$UDID" |
There was a problem hiding this comment.
P2: This unconditionally boots the selected simulator, so the job fails if the runner image already has its iPhone 17 Pro booted. Replace it with xcrun simctl bootstatus "$UDID" -b, which handles both shutdown and booted states while waiting for readiness.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/e2e.yml, line 88:
<comment>This unconditionally boots the selected simulator, so the job fails if the runner image already has its iPhone 17 Pro booted. Replace it with `xcrun simctl bootstatus "$UDID" -b`, which handles both shutdown and booted states while waiting for readiness.</comment>
<file context>
@@ -50,112 +50,126 @@ jobs:
+ xcrun simctl list runtimes
+ exit 1
+ fi
+ xcrun simctl boot "$UDID"
+ xcrun simctl bootstatus "$UDID"
+ APP=$(find build/ios -maxdepth 3 -name 'e2ereactnative.app' -type d | head -n 1)
</file context>
Suggested change
| xcrun simctl boot "$UDID" | |
| xcrun simctl bootstatus "$UDID" -b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iosandandroidjobs in.github/workflows/e2e.yml, so CI runs the suite on all three targets again.simctl create. A new simulator spent over 7 minutes on its first boot (from the closed ci(e2e): boot the runner's iPhone 17 Pro and give the iOS job 90 minutes #3).Issue
ENG-1277
Verified
Ran it locally: no - CI-only change, the iOS and Android jobs on this PR are the check.