Repository navigation
ci(e2e): run the web, iOS, and Android e2e suites on GitHub Actions - #1
Merged
Merged
Conversation
The iOS job builds a Release app, creates an iPhone 17 Pro simulator on the pinned iOS 26.5 runtime, and passes its UDID to the ios target through E2E_IOS_DEVICE.
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/e2e.yml">
<violation number="1" location=".github/workflows/e2e.yml:38">
P2: Forked pull requests do not receive repository secrets, so each E2E job runs without model credentials and fails; provide a fork-safe authentication path or avoid running these checks for fork PRs.</violation>
</file>
Forks get no repository secrets, so the agent steps would fail without AI_GATEWAY_API_KEY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/e2e.ymlruns the suite on every pull request and push tomain, one job per target:webubuntu-latestiosmacos-26expo run:ios --configuration Release --device generic --no-bundleriOS-26-5androidubuntu-latest(KVM)expo prebuild+gradlew :app:assembleReleasepixel_7ios/andandroid/are generated, so each mobile job prebuilds them. Release builds bundle their JS, so they don't depend on Metro.iPhone 17 Proon its default runtime, so the job passes its own simulator's UDID to theiostarget:--workers 1(one device each). Each job uploads.e2e/even when tests fail.AI_GATEWAY_API_KEY.Verified
Ran it locally: no - CI-only change; the workflow runs on this PR.