ci: attest release binaries - #2352
Conversation
dyoshikawa
left a comment
There was a problem hiding this comment.
This cannot be merged as-is. The attestation action requires artifact-metadata: write, so the release workflow can fail when it reaches the provenance step. The current main branch already contains the same functionality with that permission and this branch now conflicts with main; please close this superseded PR or rebase it and retain the missing permission if further changes are needed.
|
|
||
| permissions: | ||
| contents: write # Required for uploading release assets | ||
| attestations: write # Required for publishing build provenance |
There was a problem hiding this comment.
actions/attest also requires artifact-metadata: write. Without it, the provenance step can fail at release time even though this PR CI passes. Please add the permission (as current main already does) before relying on this workflow.
|
Closing as superseded, following up on my review above. main already attests the release binaries: The one piece that never landed is the "Verify build provenance" section for the installation guide. I've noted that on #2390 so it gets picked up there with the binary-name fix folded in. |
Summary:
Test plan:
Closes #2346