Open the GFS and GEFS virtual quickstarts from the catalog - #81
Merged
Merged
Conversation
Both datasets families are in the production catalog, so replace the direct Icechunk opens with dynamical_catalog.open and move the remaining imports to the first cell that uses them.
aldenks
marked this pull request as ready for review
September 23, 2026 19:30
aldenks
enabled auto-merge (squash)
September 23, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft. Must not merge before the production flip lands and deploys — see Blocking below.
Replaces the temporary direct-Icechunk cells in both virtual quickstarts with the concise
dynamical_catalog.open(...)form reading the production catalog. No staging URL override.Each notebook's opening cell already carried a
TEMPORARYcomment spelling out exactly this replacement; this applies it.Changes
noaa-gfs-forecast-analysis-virtual.ipynbnoaa-gefs-forecast-analysis-virtual.ipynblikewise, opening its four datasets and two groups.Per the same comment's instruction and the house style in
noaa-hrrr-analysis-virtual.ipynb, the remaining imports move to the first cell that uses them: in the GFS notebookcartopy.crsto the 500 hPa cell,numpyto the forecast-error cell andmatplotlib.pyplotto the animation cell. The GEFS notebook already importedmatplotlib.pyplotandpandasat first use, so only its open cell changes.icechunkandxarrayare no longer imported by either notebook.Net: 15 insertions, 63 deletions.
Blocking
These six datasets are staging-only in the production STAC catalog today, so
dynamical_catalog.open(...)cannot resolve them yet. CI will be red on this PR until all of the following happen, in order:production).stac/tree to the production catalog.Step 3 is deliberately not done yet: the outputs currently committed were produced by the direct-Icechunk cells, and re-running before the flip would only reproduce the failure. Once the catalog serves these ids, re-run both notebooks and push the refreshed outputs before marking this ready.
Ordering is also why this is a draft rather than an automerge candidate: merging it early would break two notebooks on
main.