Skip to content

[patch] Fix scrollbar behaviour #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PelayoFelgueroso wants to merge 2 commits into
base: master
Choose a base branch
from
+24 −11
Open

[patch] Fix scrollbar behaviour #2513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e0678c
Fix scrollbar behaviour
PelayoFelgueroso Jul 27, 2026
9e3ba27
add test
PelayoFelgueroso Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions packages/lib/src/text-input/Suggestions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,12 @@ const Suggestions = ({
}, [visualFocusIndex]);

return (
<SuggestionsContainer style={styles}>
<SuggestionsContainer
onMouseDown={(event) => {
event.preventDefault();
}}
style={styles}
>
{isSearching ? (
<SuggestionsSystemMessage aria-live="polite">
{translatedLabels.textInput.searchingMessage}
Expand All @@ -77,16 +82,7 @@ const Suggestions = ({
{translatedLabels.textInput.fetchingDataErrorMessage}
</SuggestionsErrorMessage>
) : (
<ul
aria-label="Suggestions"
id={id}
onMouseDown={(event) => {
event.preventDefault();
}}
ref={listboxRef}
role="listbox"
style={{ margin: 0, padding: 0 }}
>
<ul aria-label="Suggestions" id={id} ref={listboxRef} role="listbox" style={{ margin: 0, padding: 0 }}>
{suggestions.map((suggestion, index) => (
<Suggestion
highlighted={highlightedSuggestions}
Expand Down
17 changes: 17 additions & 0 deletions packages/lib/src/text-input/TextInput.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,6 +910,23 @@ describe("TextInput component synchronous autosuggest tests", () => {
expect(list).toBeTruthy();
expect(getAllByText("?").length).toBe(1);
});

test("Autosuggest scrollbar behaviour", () => {
const onChange = jest.fn();
const { getByRole, queryByRole } = render(
<DxcTextInput label="Autocomplete Countries" suggestions={countries} onChange={onChange} />
);
const input = getByRole("combobox");
fireEvent.focus(input);
const list = getByRole("listbox");
expect(list).toBeTruthy();

const suggestionsContainer = list.parentElement;
fireEvent.mouseDown(suggestionsContainer!);
expect(getByRole("listbox")).toBeTruthy();
fireEvent.blur(input);
expect(queryByRole("listbox")).toBeFalsy();
});
});

describe("TextInput component asynchronous autosuggest tests", () => {
Expand Down
Loading