Repository navigation
fix(board): promote <n> honours the shim's --backlog-file flag - #659
Merged
Merged
Conversation
Consumer shims append --backlog-file <path> to every subcommand; the promote selector parsed it as a candidate index and printed usage. Parse the flag, resolve the staging file beside the named board, keep env overrides first. Five new test cases plus a proof of done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumer shims (
<repo>/_meta/board) append--backlog-file <path>to every subcommand.board.sh promoteforwards argv verbatim tolib/board/bin/add-backlog, whose selector runsint()over every token, sopromote <n>through a shim printed usage and exited 2.promote listandpromote allnever reached the parser, which hid the break.Fix:
add-backlogparses--backlog-file, resolves the staging file beside the named board, and keeps the env overrides first. A dangling flag is a usage error.Proof:
docs/verification/board-promote-backlog-file.md.tests/test-board-promote.sh34 of 34 (5 new); negative control on the unpatched file fails exactly the 3 shim cases;tests/run-all.shall 151 suites green; the real ops-toolkit shim reaches the selector withDWARVES_KITpointed at this branch.Staged candidate in
_meta/backlog-staging.md(uncommitted on master, from the same session) describes this row.