Sync/public 1.1 code#88
Merged
Merged
Conversation
(cherry picked from commit 7630a124c8e732383a544ed28339af8f18a544e6)
(cherry picked from commit 229d62edc98b8faddc27f3476a6ab5e2a3ece63e)
(cherry picked from commit 1176fd45ecde950126c1d8c392bb31f6faed80de)
(cherry picked from commit bf5a91e1ae1e345e48630a57d2927a5c33c9d0cc)
(cherry picked from commit f6130411ca27fd890fe953e4a0d590200f92bcfc)
Added link of exponential time spacing to time scheme documentation (cherry picked from commit 797d3ff4f6159d436e4594fbacb21057caa078fa)
…ation function. (cherry picked from commit 5345b4316dba3164b5b549996aff6de4572079c8)
(cherry picked from commit fcfc2d98cf293bd2d85089723b7402d4d8e01067)
…st computation in MD, which makes the multithreaded math less significant than the memory bandwidth. Solving memory-related scalability issue would demand a massive change to the structure of the codebase (cherry picked from commit f8b46f792b55734da1e13d2f2f628ac59e97520a)
Added more links to other documentation pages, and also updated citation section (cherry picked from commit b9c795b1e1f7613c7af721f3fd7d9d4cd5699748)
…tion. Tested all the above analysis for bin_list (cherry picked from commit 6c74f818866f9d1ea9686c3aca96dca075337261)
…Rs to pass because PRs haven't had any tags to it yet (cherry picked from commit f1293d9029bbb9e725d1c0dbbaac5765e08e00b4)
(cherry picked from commit 538c146ecd78ad4d6f2b4876c0afa5401884b47e)
…C++ compiler in environment.yml (cherry picked from commit 6809bb7d2c0c9f13eec213418c19dcd1c411cba9)
(cherry picked from commit 879aaa9ced9311edc22a57d0dca5c897a319735f)
(cherry picked from commit d096985634153d4127e4059ddf2ca2569ae7501e)
…push (cherry picked from commit 37f3f45cb2d1dbc86b2f99a735fa3d9d6c7b0760)
Started page to document intermediate scattering function analysis correctly (cherry picked from commit 88a17cf8d24497ecc0b318a8c908c11a3288b29d)
Update list of commands to point to corrected page for isf documentation. (cherry picked from commit c5999747f82ea2faee4bf90fac0b4cf349dbf515)
…, and enables multithreading for Radial Distribution Function (cherry picked from commit 986663ff73527948aa823eac9d52080af78b71a0)
(cherry picked from commit 5dea40f2cd09c73e1c08834fa57aaf0ad313d9df)
(cherry picked from commit 80a0f72dfc3fe64171ca46d792b9d79dc90a51f8)
Change general manual wording to reflect partial implementation of multithreading. (cherry picked from commit 79c079a21e69488220d80191fc6cc8c180bd73a5)
Creating stub page for multithreading documentation. (cherry picked from commit 7c0cd87e030b9c6ddf19a6ef3ac856cdd8c7c44b)
Added flag for multithreaded. (cherry picked from commit a16651834d485384431a1f8519db3dc273cfe2f7)
Updated multithreading documentation. (cherry picked from commit 6f7a4b871a70aedbb15679304172b39540f8a18b)
More multithreading documentation. (cherry picked from commit 243e5ec3b11609e6da3f6a6f5d801690981aa417)
Updates the multithreading documentation initially (cherry picked from commit 044c2d98ef78ed5bfe831e715d2697915477ae70)
Added a badge for multithreading to the mean displacement documentation. (cherry picked from commit 6e10078bc2fbcd5d5b6cb7494fa2b915172c08b9)
(cherry picked from commit 31be0e63626e0d9ec4037a53a0f25601e8606fbe)
…orrelation (cherry picked from commit e3e8689fb93906d5b8e31132ad1f577617dfe34f)
(cherry picked from commit 9821b957ace56f11c456a2d796011dbc248cb4a7)
typo fix (cherry picked from commit f20e233b3597d45a70060faf5719167d0bf203e4)
…heck before while integrating multithreading due to inexperience in tags and version control in Github. I will now enable it again.) (cherry picked from commit a9dcd840af3c1dfd2df64d301b11cf74fd76c1ab)
(cherry picked from commit 971e40377dbe67190c2c98cff271343c7ad8365f)
…ajectories (cherry picked from commit 84ae88838522dd6448a119fedb5db3c57bca6196)
Removed developer-focused element of documention to be added to a separate dev documentation later. (cherry picked from commit d086944f016da9c60f5946ebbd11ef62457928cc)
Minor update to make the two write methods of this class consistent. Should have no impact on current functionality. (cherry picked from commit ea2ff0b7c126944ee57d5e78973b779af86b2e48)
Improves documentation to explain fields in output file. (cherry picked from commit 99b51f2a47b50743b2e2b57ec7c0a1b6e193cc1b)
…ts of multibodies with at least n beads contained within a specified trajectory list at each time (cherry picked from commit c60f9a9e82c634fcb11807605c33e3ff43b40907)
Add stub for new multibody_trajlist_intersection tool (cherry picked from commit 2574c7f62e804be2ac1da2babc1e81bb8b9beeab)
formatting fix (cherry picked from commit a4d2d310c5c30bafc137d7ff58f12e25e8341a2a)
documented new multibody_trajlist_intersection capability (cherry picked from commit 0fd3d79b529bf4cd711e3632ad75f22b8fce5b45)
'baf' is a depracated command which is currently undocumented. (cherry picked from commit 2d2923682c1f3c42488505573e0605dd394dcd8d)
(cherry picked from commit 4ca3e3ab0fe9dfb552a8962dae22fdd9187da128)
Fixed formatting and improved clarity in the neighborlist documentation. (cherry picked from commit 4a6d887373c7c69b8bea0f89b5012f3f0528b686)
This reverts commit 8cbf1ceab637de04e223b8a2e3bfc8f19fa34969. (cherry picked from commit 827ae1fc2fe5b0b1cdf258c4623390f14ce0a9cc)
(cherry picked from commit 970a06c17a8a132386efb999fcb842945a417808)
(cherry picked from commit 7d7d9f9394836aa069def7dda6cfe3b3286b4ba0)
(cherry picked from commit d52b8b1e00ecefb0d16252defcdf95424a202898)
(cherry picked from commit 4f0eacbc6ccbc7e7384e99dede267652e3d3b071)
(cherry picked from commit 73019e8447710a96adc1e82cb75e2620e8a4a2aa)
(cherry picked from commit a34f76b5d7e0efb151a052b84cda1439f4924e82)
(cherry picked from commit 0e69d5ebf26134abf0fafc6063f67e551e16ea8d)
(cherry picked from commit 4e1b77fc91e146db81c4b4d55204f4143221fd46)
BaoKhanhMa
approved these changes
Jul 21, 2026
BaoKhanhMa
left a comment
Member
There was a problem hiding this comment.
Hi Pierre, I checked your PR, and this is what I see:
- All supported analyses are correctly enabled with multithreading flag
- The core loop is correctly opened with #pragma and is not commented out
- You updated PADDING using array<> instead of ** (pointers to pointers)
- Added multibody_trajlist_intersection.cpp
- There is no leftover inside control.cpp
- Github workflow now has an automatic test system with msd, msd2d, and baf, and it accepts a small tolerance compared to the fixed result
I think your PR is ready to be merged, but do you mind if I make a small suggestion? I noticed that "tests"and "testfiles" have very similar names so I wonder if we should rename "testfiles" to something like "samples" to distinguish them? Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMDAT 1.1.0
AMDAT now supports OpenMP multithreading across numerous analyses, substantially reducing execution time while preserving existing input workflows and numerical results.
Highlights
The multithreading implementation, benchmarking, and performance measurements were contributed by @BaoKhanhMa.
Multithreaded analyses
mdmsdmsd_2disfsvhsvhdrafngpcompositionrdfrnforientational_correlationneighbor_decorrelation_functionMaximum speedups are benchmark results and may vary with the analysis, input data, thread count, and hardware.
Migration notes
No user action is required. OpenMP support is provided by the conda toolchain, and existing AMDAT input files remain compatible.
Automated testing
git describemetadata refresh correctly.