chore: fix integ test - #2467
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR updates SQL Server DSC integration test descriptions and selected assertions to represent ChangesTest-DscConfiguration result normalization
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Around line 15-17: Update the SqlServerDsc changelog entry so both clauses use
“returns” instead of “return,” while preserving the existing wording and
formatting.
In `@tests/Integration/Resources/DSC_SqlAgentAlert.Integration.Tests.ps1`:
- Line 114: Update the affected It descriptions so every description starts with
“Should” and removes “when”, while preserving each test’s intended behavior.
Apply this to all listed descriptions in
tests/Integration/Resources/DSC_SqlAgentAlert.Integration.Tests.ps1 (114, 166),
DSC_SqlAgentFailsafe.Integration.Tests.ps1 (105, 157),
DSC_SqlAgentOperator.Integration.Tests.ps1 (105, 157, 209, 261),
DSC_SqlAlwaysOnService.Integration.Tests.ps1 (156, 206),
DSC_SqlScriptQuery.Integration.Tests.ps1 (146-148, 201-203, 294-296), and
DSC_SqlWindowsFirewall.Integration.Tests.ps1 (143-144).
In `@tests/Integration/Resources/DSC_SqlRSSetup.Integration.Tests.ps1`:
- Line 186: Update every affected Pester It description so it starts with
“Should” and contains no “when”; use outcome-focused wording such as “Should
return True from Test-DscConfiguration.” Apply this to
tests/Integration/Resources/DSC_SqlRSSetup.Integration.Tests.ps1:186-186;
DSC_SqlRS_Default.Integration.Tests.ps1:169-169, 343-343, 413-413;
DSC_SqlReplication.Integration.Tests.ps1:141-141, 196-196, 251-251, 306-306;
DSC_SqlScript.Integration.Tests.ps1:184-186, 239-241, 332-334, 425-427;
DSC_SqlSecureConnection.Integration.Tests.ps1:119-119, 171-171;
DSC_SqlServiceAccount.Integration.Tests.ps1:146-146, 197-197, 248-248, 299-299,
383-383, 434-434, 485-485, 536-536; and
DSC_SqlSetup.Integration.Tests.ps1:253-253, 390-390, 544-544, 704-704, 864-864.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3f0bc365-6099-4176-b64c-2c638821820a
📒 Files selected for processing (28)
CHANGELOG.mdtests/Integration/Resources/DSC_SqlAgentAlert.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlAgentFailsafe.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlAgentOperator.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlAlwaysOnService.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlAudit.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlDatabase.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlDatabaseDefaultLocation.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlDatabaseMail.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlDatabaseObjectPermission.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlDatabasePermission.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlDatabaseUser.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlEndpoint.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlLogin.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlPermission.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlProtocol.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlProtocolTcpIp.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlRS.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlRSSetup.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlRS_Default.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlReplication.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlRole.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlScript.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlScriptQuery.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlSecureConnection.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlServiceAccount.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlSetup.Integration.Tests.ps1tests/Integration/Resources/DSC_SqlWindowsFirewall.Integration.Tests.ps1
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
=====================================
Coverage 94% 94%
=====================================
Files 227 227
Lines 10871 10871
=====================================
+ Hits 10234 10235 +1
+ Misses 637 636 -1
🚀 New features to boost your workflow:
|
…r case sensitivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Test-DscConfigurationreturn
$truewhen it is in fact return the string value'True'.This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is