SqlServerDsc: Update tests to Pester 6 syntax where supported - #2465
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 438 files, which is 288 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (438)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
=====================================
- Coverage 94% 94% -1%
=====================================
Files 227 227
Lines 10871 10871
=====================================
- Hits 10235 10234 -1
- Misses 636 637 +1
🚀 New features to boost your workflow:
|
… Should-NotInvoke - Changed all instances of 'Should:ModuleName' to 'Should-Invoke:ModuleName' and 'Should-NotInvoke:ModuleName' in various test scripts. - Updated BeforeAll and AfterAll blocks in the following test files: - Test-SqlDscIsLogin.Tests.ps1 - Test-SqlDscIsLoginEnabled.Tests.ps1 - Test-SqlDscIsRole.Tests.ps1 - Test-SqlDscIsSupportedFeature.Tests.ps1 - Test-SqlDscRSAccessible.Tests.ps1 - Test-SqlDscRSInitialized.Tests.ps1 - Test-SqlDscRSInstalled.Tests.ps1 - Test-SqlDscServerPermission.Tests.ps1 - Uninstall-SqlDscPowerBIReportServer.Tests.ps1 - Uninstall-SqlDscReportingService.Tests.ps1 - Uninstall-SqlDscServer.Tests.ps1 - Update-SqlDscServer.Tests.ps1 - Update-SqlDscServerEdition.Tests.ps1 - Connect-Sql.Tests.ps1 - Connect-SqlAnalysis.Tests.ps1 - Connect-UncPath.Tests.ps1 - ConvertTo-ServerInstanceName.Tests.ps1 - Copy-ItemWithRobocopy.Tests.ps1 - Disconnect-UncPath.Tests.ps1 - Find-ExceptionByNumber.Tests.ps1 - Get-PrimaryReplicaServerObject.Tests.ps1 - Get-ServiceAccount.Tests.ps1 - Get-SqlInstanceMajorVersion.Tests.ps1 - Invoke-InstallationMediaCopy.Tests.ps1 - Invoke-SqlScript.Tests.ps1 - Restart-SqlClusterService.Tests.ps1 - Restart-SqlService.Tests.ps1 - Split-FullSqlInstanceName.Tests.ps1 - Start-SqlSetupProcess.Tests.ps1 - Test-ActiveNode.Tests.ps1 - Test-AvailabilityReplicaSeedingModeAutomatic.Tests.ps1 - Test-ClusterPermissions.Tests.ps1 - Test-FeatureFlag.Tests.ps1 - Test-ImpersonatePermissions.Tests.ps1 - Test-LoginEffectivePermissions.Tests.ps1 - Update-AvailabilityGroupReplica.Tests.ps1
- Updated all test scripts to replace references of `$script:dscModuleName` with `$script:moduleName` for the `Should-Invoke` and `Should-NotInvoke` parameters in the `BeforeAll` block.
…er command behavior
…e:ModuleName' and 'Should-NotInvoke:ModuleName' for consistency with Pester 6
…datory checks
- Updated tests for various SQL DSC commands to replace direct checks for mandatory attributes with Should-All { $_ | Should-BeTrue } for better readability and consistency.
- Ensured that non-mandatory parameters are checked using Should-All { $_ | Should-BeFalse } where applicable.
- This change applies to tests across multiple files including Disable-SqlDscDatabaseSnapshotIsolation, Enable-SqlDscLogin, Get-SqlDscAgentAlert, and others.
…start and SuppressRestart
…consistency - Updated multiple unit test files to replace the use of inline script blocks with -FilterScript in assertions for parameter attributes. - Ensured that mandatory and non-mandatory parameter checks are consistently using the same validation method across various test files. - This change improves readability and maintains a uniform approach to parameter validation in the tests.
…ssertions - Updated parameter handling in multiple test scripts to use 'Should:ModuleName' instead of 'Should-Invoke:ModuleName' and 'Should-NotInvoke:ModuleName'. - Replaced 'Should -MatchExactly' assertions with 'Should-MatchString -CaseSensitive' for better clarity and consistency in tests. - Adjusted various test cases to ensure proper invocation and parameter filtering for SQL setup processes. - Enhanced type checking in tests to ensure expected object types are returned. - Cleaned up redundant code and improved readability across multiple test files.
…ccounts assertions
…sertions and update type checks for consistency
…g for better traceability
… depth overflow comments
…and improve debug logging
…d remove debug logging
johlju
force-pushed
the
f/pester-6-attempt-2
branch
from
July 8, 2026 11:37
a9232be to
6db6510
Compare
johlju
marked this pull request as ready for review
July 8, 2026 13:30
johlju
commented
Jul 10, 2026
johlju
left a comment
johlju
left a comment
Member
Author
There was a problem hiding this comment.
@johlju reviewed 438 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on johlju).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
None.
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is