feat: Add adapted resource manifest generation - #2461
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (3)
WalkthroughAdds ChangesBuild Configuration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@build.yaml`:
- Line 15: The build references a missing Invoke-Build task named
Create_DscResourceManifestsList which causes invocation to fail; either remove
the Create_DscResourceManifestsList entry from the build workflow or add a
corresponding task definition in an *.ib.tasks file (and export it from the
DscResource.Authoring module if required) so Invoke-Build can discover it—update
the build.yaml workflow to no longer call Create_DscResourceManifestsList if you
remove the task, or create a properly named Create_DscResourceManifestsList task
implementation and ensure it is exported/imported where tasks are loaded.
In `@CHANGELOG.md`:
- Around line 10-11: Update the Unreleased CHANGELOG.md entry for "SqlServerDsc"
by appending the related issue reference in the required Markdown format; modify
the entry "- Added adapted resource manifest generation to the build pipeline."
to include the issue link like "([issue
#<number>](https://github.com/dsccommunity/SqlServerDsc/issues/<number>))" so
the line reads with the issue reference at the end.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a0757a1e-b725-48f4-b004-5c68063bd711
📒 Files selected for processing (3)
CHANGELOG.mdRequiredModules.psd1build.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2461 +/- ##
=====================================
- Coverage 94% 94% -1%
=====================================
Files 227 227
Lines 10871 10871
=====================================
- Hits 10235 10234 -1
- Misses 636 637 +1
🚀 New features to boost your workflow:
|
|
Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again. |
|
Will get to this. Just a lot of stuff at work and private 🙂 But haven't forgotten. |
2f194f4 to
1f5c1e1
Compare
johlju
left a comment
There was a problem hiding this comment.
@johlju reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Gijsreyn).
Pull Request (PR) description
This pull request adds a new task to create an adapted resource manifest (
*.dsc.manifests.json) after the build succeeds. This adapted manifest can be shipped alongside the module, so that Microsoft's DSC engine can find it using the PowerShell discovery extension.Note
For more information on the working, check out the excellent Wiki docs.
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is