Repository navigation
feat(strategies): add composed backtest attribution - #1217
Conversation
|
Someone is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Shalombonet Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
collinsezedike
left a comment
There was a problem hiding this comment.
@Shalombonet the composed attribution itself looks sound. Two unrelated files need to come out before this can merge. See inline.
|
I removed the generated AGENTS.md from the PR and restored the root tsconfig.json. |
collinsezedike
left a comment
There was a problem hiding this comment.
@Shalombonet the composed attribution path covers the issue's acceptance criteria. Please make the funding-payment id non-breaking, and re-author the commits with an email linked to your GitHub account so they resolve to you. See the inline note.
8f60954 to
2e323d2
Compare
collinsezedike
left a comment
There was a problem hiding this comment.
Thank you @Shalombonet. The funding transaction id is now optional and the merge is clean. The attribution path and its tests cover the issue's acceptance criteria. If you would like to pick up another open issue, there are several in the tracker.
Thank you for the review @collinsezedike . I’m glad the attribution path and tests cover the acceptance criteria. Since the merge is clean, could you please merge this PR and close it when you have a moment? I’d also be happy to pick up another open issue afterward. Thanks again for your time and guidance. |
|
@Shalombonet thank you again for getting this over the line, and thank you for starring the repository. If you'd like to pick up another open issue, there are several available in the tracker. |
Summary
runComposedBacktestusing the existing backtest runner.Test plan
pnpm --filter @meridian/strategies test(747 tests passed)pnpm --filter @meridian/strategies typecheckpnpm --filter @meridian/strategies lintnpx tsc --noEmitCloses #1200