Skip to content

✨ Theme accent color, optional card, onPageShown callback - #9

Merged
dryan merged 1 commit into
stable-page-listfrom
theme-accent-card-callback
Oct 2, 2026
Merged

dryan merged 1 commit into
stable-page-listfrom
theme-accent-card-callback

Conversation

@dryan-gh-actions

Copy link
Copy Markdown
Contributor

Three things a faithful CrumbDB port needs:

  • OnboardingTheme.accentColor (defaults to primaryColor) drives the
    header icon, the footer buttons, and the current dot, so an app with
    orange highlights and Moss text keeps both.
  • cardBackground is optional and, when set, OnboardingStepView draws
    the header and content inside a rounded card filled with it.
  • OnboardingFlowView.onPageShown fires once per page shown (first page
    on appear, then every change), for page-view analytics; onAppear on
    page content can't do it since every page is created up front.

Tests: 39, all passing.

Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com

Three things a faithful CrumbDB port needs:

- OnboardingTheme.accentColor (defaults to primaryColor) drives the
  header icon, the footer buttons, and the current dot, so an app with
  orange highlights and Moss text keeps both.
- cardBackground is optional and, when set, OnboardingStepView draws
  the header and content inside a rounded card filled with it.
- OnboardingFlowView.onPageShown fires once per page shown (first page
  on appear, then every change), for page-view analytics; onAppear on
  page content can't do it since every page is created up front.

Tests: 39, all passing.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@dryan-gh-actions
dryan-gh-actions Bot requested a review from a team October 2, 2026 15:59
@dryan
dryan merged commit 61e9b29 into stable-page-list Oct 2, 2026
1 check passed
@dryan
dryan deleted the theme-accent-card-callback branch October 2, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant