Make semver checks exclude unstable types - #204
Merged
wfraser merged 5 commits intoJul 27, 2026
Conversation
this is only really needed on Windows, where Python likes to assume we're using CP-1252 like it's 1997 or something
wfraser
changed the title
wfraser
force-pushed
the
semver-checks-exclude-unstable-types
branch
from
July 26, 2026 03:06
e9fc675 to
3994377
Compare
use the unstable feature insted
We have a real programming language (well, if Python counts, lol), so no need to use jq shenanigans.
wfraser
force-pushed
the
semver-checks-exclude-unstable-types
branch
from
July 27, 2026 19:09
3994377 to
76ffa63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially fixes #111, specifically the "don't test unstable things" part. I haven't extended it to deprecated things yet.
Checklist
General Contributing
RELEASE_NOTES.mdfile, or believe it's not necessary for this change.Validation
The current pending API spec update makes a lot of breaking changes, but they're all in the riviera namespace, which is all unstable. The current
update_spec.pyfails and says it's semver-incompatible, but with this change, the tests of the riviera namespace types are config'd out, and the tests pass.