Repository navigation
test: accept the iOS 27 "Start Sharing" broadcast label - #36
Merged
Merged
Conversation
iOS 27 keeps ReplayKit's CONTROL_CENTER_START_BROADCAST key but renames its text from "Start Broadcast" to "Start Sharing" (German "Jetzt teilen"). The key-based lookup already resolves the new labels; the unit test asserted the old iOS 26 text and failed on the Xcode 27 simulator. Also add "Start Sharing" to the English last-resort labels. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
niko-droidrun
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #35.
Problem
FBBroadcastLabelsTests testStartBroadcastLabelCoversNonEnglishLanguagesfails on the Xcode 27 / iOS 27 simulator (iPhone_Unit_Test_Max_Xcode).iOS 27 keeps ReplayKit's
CONTROL_CENTER_START_BROADCASTkey but renames its text:The key-based lookup from #35 already resolves the new labels. Only the test was wrong, because it asserted the iOS 26 text.
Change
"Start Sharing"is added to the English last-resort labels, which are used only if the key is ever missing.docs/broadcast-extension.mdnote the rename.Testing
FBBroadcastLabelsTestspasses on the iOS 27.0 and iOS 26.5 simulators.WebDriverAgentLibbuilds forgeneric/platform=iOSwith no new warnings.🤖 Generated with Claude Code