Repository navigation
Re-evaluate Hera pane size-drift kick on Ctrl+Z fullscreen toggle - #1064
Merged
Merged
Conversation
A fullscreen toggle changes the focused pane's width without rebinding it, so the per-bind kickedFor gate swallowed the re-evaluation and the zoomed pane kept split-width history (and unzoom kept zoom-width content). Re-arm behind a fresh KickDebounce dwell when a layout shift moves the width; retry when a kick is already in flight; log non-forced PTY resizes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
anutron
force-pushed
the
argus/argus-agent-death/fix-zoom-width
branch
from
October 19, 2026 21:25
a7fb345 to
1479278
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ctrl+Z zoom of a Hera pane changes its width without rebinding it.
maybeKickPaneRerender's per-bindkickedForgate then short-circuited, so the size-drift kill+resume never re-ran. The zoomed pane kept split-width (88) history, and unzoom kept zoom-width content in the narrow pane, until a rebind (leaving and returning to the TUI) re-evaluated.Fix (TUI-side only; no supervisor/protocol change)
HeraPage.Drawflags a one-framelayoutShiftedwhen the fullscreen/focus layout changes.maybeKickPaneRerenderre-arms behind a freshKickDebouncedwell only if the pane's last-seen width moved. Rapid toggling collapses into one evaluation, andisRedundantAttachstill dedupes same-width repeats.maybeKickRerenderAtWidth's "kick in flight" early return now callsonDeferred, so a toggle landing mid-restart retries.[terminalpane] pty resize OLD -> NEW), fullscreen width-change re-arm, and kick evaluation.hera-view.mdandindex.md. No OpenSpec change (bug fix, no new behavior surface).Tests
TestPanes_FullscreenToggleRearmsKick(red before the fix)TestRerender_InFlightKickInvokesOnDeferredTestTerminalPane_NonForcedResizeIsLoggedmake test-cover-gatepasses (88.8%).make vulnfails on stdlib CVEs, which CI treats as advisory. fmt-check and lint-pr passed.🤖 Generated with Claude Code