Repository navigation
Make agent-view Cmd+Up/Down skip hidden hera tasks; raise local test timeout to 200s - #1063
Merged
Merged
Conversation
AdjacentTask walked the raw task slice, so with hera-managed tasks hidden (H) Cmd+Up/Down still landed on hidden hera workers and coordinators. It now walks scanOrder, the same visible order the list renders: filter and hide-hera-managed applied, Pinned -> Active -> Archive. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
internal/tui alone runs ~1,300 serial tests in ~123s under -race on a normal dev machine, so the 120s per-package timeout failed it deterministically. CI runs without -timeout and is unaffected. Update the ci-gates notes that forbade raising it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
150s still tripped internal/tui (144s at -p=1) under a load spike; give it real headroom. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdjacentTaskwalked the raw task slice; it now walksscanOrder, the same visible order the list renders (filter and hide-hera-managed applied; Pinned → Active → Archive; folded projects still reachable). If the current task isn't visible, the chord does nothing.task-list-view, archived in this PR (openspec/changes/archive/2026-10-19-fix-agent-task-nav-visibility).internal/tuitakes ~123s under-race(~1,300 serial tests, none over 1.7s), so the 120s per-package timeout failed it every time on a dev machine. Same result with this change reverted, so the slowness predates it. CI runs without-timeoutand isn't affected. Updated theci-gates.mdnotes that said not to raise it.Parity
The web SPA and macOS app aren't affected: the hide toggle only exists in the TUI, and the macOS Cmd+Up/Down walks its own sidebar list.
Test plan
TestTaskListView_AdjacentTask_HonorsVisibility(hidden hera skipped, shown when not hidden, filter, pinned-first order). It fails on the old code by landing on the hidden worker.TestTaskListView_AdjacentTaskstill passesGOFLAGS=-p=1 make test-cover-gate: green, 88.8% (floor 88)make vulnfails on go1.26.8 stdlib advisories (net/http, crypto/tls, net/textproto). CI runs it ascontinue-on-error.🤖 Generated with Claude Code