Repository navigation
Show LAUNCH splash in Hera panes while a role's task launches - #1060
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rrow rects Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…respawn Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merging this branch changes the coverage (1 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DrawPendingBanneris now a wrapper overwidget.DrawLaunchBanner(subtitle).pending+ no session →P R E P A R I N G W O R K T R E E . . .; live session with zero bytes ever written →S T A R T I N G A G E N T . . ..HeraPage.syncLaunchStatuspushes the bound task's status to each pane after every selection/refresh.screen.Sync(). Opt-in per pane (EnableLaunchSplash); uxlog on stage transitions/timeouts.Frontend parity
Neither the web SPA nor the macOS app has a launch splash for tasks today, so there is no Hera equivalent to port. Named in the OpenSpec Non-Goals. Also non-goals: planned (no task row yet) plan nodes, and a distinct pre-DB worktree stage (the task row only exists after the worktree does).
Specs / docs
OpenSpec change
add-hera-launch-splasharchived in-PR (delta merged intoopenspec/specs/hera-view/spec.md); gotcha bullet inhera-view.md+ index row.Verification (ambient ARGUS_/CODEX_ scrubbed; rebased onto master adfcfd9 / #1054)
make build vet fmt-check lint-pr: clean.make vuln: fails only on Go stdlib CVEs (advisory in CI) — waived.make test-cover-gate: three packages failed under full-suite load (internal/agent and internal/tui hit the 2m package timeout; internal/daemon/client and TestSupAcctEnv failed alongside). Isolatedgo test -race -count=1 -timeout 10mreruns all pass: internal/agent 91.9s, internal/daemon/client 27.8s, internal/tui 262.7s (load-induced waiver). The aggregate coverage floor number was not produced because the gate aborted; new code is 100% covered (launchsplash.go, syncLaunchStatus, DrawLaunchBanner).🤖 Generated with Claude Code