Conversation
Replicates the cue editor's CSS :has() pattern — when the user hovers the Edit button or dropdown caret in the script viewer, the full row gets a subtle background highlight to make the target line clear. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
small-diff
Tim020
added
release
* Fix cut mode in V3 script editor: clickable links and clean exit Bug 1: canEdit was computed as `isEditor && !cutMode`, so lines were never rendered as clickable cut anchors (required canEdit && isCutMode). Fix: canEdit = isEditor only (matching V2 behaviour); all edit-only surfaces already have independent !isCutMode guards. Bug 2: stopEditing() always called emptyScript() + loadPage() causing a blank-page flash. Also, currentEditor was not cleared synchronously, so edit buttons briefly appeared after setCutMode(false) before the WS response arrived. Fix: skip the reload in cut mode (tmpScript is never modified), and clear currentEditor synchronously before sending STOP_SCRIPT_EDIT. Adds 6 Playwright E2E tests covering the full cut mode workflow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix Prettier formatting in ScriptEditor.vue Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
small-diff
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit 9f519f6. ♻️ This comment has been updated with latest results. |
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit 9f519f6. ♻️ This comment has been updated with latest results. |
Python Test Results 1 files 1 suites 2m 7s ⏱️ Results for commit 9f519f6. ♻️ This comment has been updated with latest results. |
Playwright E2E Results (chromium)175 tests 175 ✅ 1m 52s ⏱️ Results for commit 9f519f6. ♻️ This comment has been updated with latest results. |
Playwright E2E Results (firefox)175 tests 175 ✅ 1m 50s ⏱️ Results for commit 9f519f6. ♻️ This comment has been updated with latest results. |
* Add rows per page selector to all paginated tables (#1164) Adds a PaginationControls shared component to every paginated table in both client/ (Vue 2) and client-v3/ (Vue 3) — options 10, 15, 25, 50, All with 15 as the default. Selecting "All" (value 0) shows all rows and hides the page navigation. A usePagination composable bundles perPage + currentPage refs with an auto-reset watcher for the Vue 3 client. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Extract pagination watch into paginationMixin (client/) The rowsPerPage→currentPage reset watcher was duplicated across all single-table components. A new paginationMixin centralises rowsPerPage, currentPage and the watch in one place; components just declare mixins: [paginationMixin] and drop the duplicated data/watch blocks. ConfigSystem's non-standard perPage/currentPageClients fields were also renamed to match the mixin, standardising its default from 5 to 15. Multi-table components (PropsList, SceneryList, StageManager) retain their own watches as they reset multiple independent page counters. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix pagination controls alignment and E2E test locators - Add mb-0 to b-pagination in client/ (Bootstrap 4 reboot gives <ul> margin-bottom:1rem; applying mb-0 directly to the rendered <ul> removes it) - Add :deep(.pagination){margin-bottom:0} in client-v3/ (BPagination wraps the <ul> in a <nav>; class on BPagination targets the nav, so the child ul's margin must be reset via scoped CSS to prevent it inflating the flex item's height and pushing the buttons above the centre line) - Fix E2E strict-mode violation: scope 'Rows per page' label assertion to the PaginationControls container via nav[aria-controls="character-table"] parent, since BTabs keeps all tab panes in the DOM simultaneously - Fix E2E third test: use nav[aria-controls="character-table"] directly (the nav IS the element with aria-controls; previous locator searched for a nav inside the nav, trivially matching zero elements) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Restore bottom spacing on PaginationControls via mb-3 on wrapper The pagination ul's margin-bottom:1rem was removed to fix flex alignment, but it was also providing visual breathing room below the controls. Add mb-3 (=1rem) to the outer wrapper div to restore that spacing explicitly, separating the two concerns. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Hide pagination controls when rows don't warrant them; fix E2E locators Component behaviour: - Entire PaginationControls hidden when totalRows ≤ smallest option (10); no point offering a rows-per-page selector when there isn't enough data to paginate even at the tightest setting - Pagination nav hidden when totalRows ≤ perPage (all rows fit on one page) or when perPage = 0 (All selected) - Both conditions derived from PER_PAGE_OPTIONS so the threshold stays in sync with the options array automatically E2E fixes (06-show-config-characters.spec.ts): - BVN renders BPagination as <ul role="menubar">, not <nav> — aria-controls lives on each <button class="page-link">, not on a nav wrapper; replaced all nav[aria-controls] locators with select#<id> and button[aria-controls] - Added test verifying controls are hidden with 1 character (below threshold) - Added loop that creates 10 extra characters (11 total) to bring totalRows above the minimum, then tests selector visibility, options, and nav show/hide behaviour end-to-end Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.