Fix/cn daily query

[dp9u0]

Problem

lc show -d failed with [ERROR] http error [code=400] against leetcode.cn since 2026-09-13. All other commands (show <id>, list, test, submit) kept working.

Root cause

The daily query in lib/plugins/leetcode.js uses activeDailyCodingChallengeQuestion, which exists only in leetcode.com's GraphQL schema. leetcode.cn rejects it:

{"errors":[{"message":"Cannot query field \"activeDailyCodingChallengeQuestion\" on type \"Query\"."}]}

The cn-only field is todayRecord. Both endpoints were tested live: each returns 200 only for its own field, so the query must branch per endpoint.

Fix

Add a getProblemOfToday override in lib/plugins/leetcode.cn.js using todayRecord { question { titleSlug } }, mirroring the plugin's existing getProblems override pattern. The returned slug flows through the unchanged core detail-fetch path. The leetcode.com implementation is untouched.

Verification

• lc show -d (global install, linked to this tree, leetcode.cn plugin enabled) prints [836] 矩形重叠 with the full translated description.
• eslint clean.
• Note: 3 plugin:cache login tests fail locally due to this machine's stale ~/.lc state (clean CI runners should be unaffected); plugin #Plugin.copy is network-flaky.

[Copilot]

🟡 Changes recommended

Unresolved critical and moderate issues remain in session deletion, cache invalidation, HTTP/authentication, bulk submissions, and package compatibility.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This pull request fixes daily problem lookup for leetcode.cn and modernizes related CLI, API, HTTP, caching, tooling, and test behavior.

Changes:

• Adds the CN-specific todayRecord daily query.
• Updates translation-aware APIs, authentication, caching, and command flows.
• Refreshes dependencies, templates, documentation, workflows, and tests.

File summaries

File	Summary
test/test_plugin.js	Plugin installation tests
test/test_log.js	Logging and exit-code tests
test/test_helper.js	Helper and language tests
test/test_file.js	File and plugin discovery tests
test/test_core.js	Core and daily retrieval tests
test/plugins/test_retry.js	Retry behavior tests
test/plugins/test_leetcode.js	LeetCode API and authentication tests
test/plugins/test_cache.js	Cache behavior tests
test/mock/find-the-difference.json.20171216	API fixture
test/mock/find-the-difference-unstar.json.20200821	Favorite-state fixture
test/mock/find-the-difference-star.json.20200821	Favorite-state fixture
test/mock/add-two-numbers.20161015.json	API fixture
test/commands/test_user.js	User command tests
test/commands/test_submission.js	Submission command tests
test/commands/test_stat.js	Statistics command tests
test/commands/test_show.js	Show command tests
test/commands/test_list.js	List command tests
test/commands/test_cache.js	Cache command tests
templates/detailed.tpl	Detailed output template
templates/codeonly.tpl	Code-only output template
README.md	CLI documentation
package.json	Dependencies, binaries, and scripts
lib/session.js	Session and cache management
lib/plugins/solution.discuss.js	Discussion solution integration
lib/plugins/retry.js	Retry and relogin behavior
lib/plugins/leetcode.js	Shared API and authentication logic
lib/plugins/leetcode.cn.js	CN endpoint and daily query
lib/plugins/cache.js	Cache freshness and invalidation
lib/plugin.js	Plugin installation
lib/log.js	Logging and exit signaling
lib/http.js	HTTP compatibility layer
lib/helper.js	Input, language, and cache helpers
lib/file.js	File and code-marker handling
lib/core.js	Translation-aware core APIs
lib/config.js	URLs, languages, and initialization
lib/commands/version.js	Version command
lib/commands/user.js	User command behavior
lib/commands/test.js	Test result presentation
lib/commands/submit.js	Submission result presentation
lib/commands/submission.js	Submission download flow
lib/commands/stat.js	Statistics command
lib/commands/star.js	Favorite management
lib/commands/show.js	Problem detail and daily output
lib/commands/session.js	Session management
lib/commands/list.js	Problem listing
lib/commands/config.js	Configuration command
lib/commands/cache.js	Cache command
lib/cli.js	CLI initialization
lib/cache.js	Bulk cache operations
eslint.config.js	ESLint configuration
docs/releases.md	Release documentation
docs/install.md	Installation documentation
docs/index.html	Documentation site page
docs/demo.html	Documentation demo page
docs/commands.md	Command documentation
docs/advanced.md	Advanced documentation
docs/_config.yml	Documentation configuration
1.js	Sample generated solution
.vscode/launch.json	Debug launch configurations
.travis.yml	Legacy CI configuration
.npmignore	Package exclusions
.github/workflows/release.yml	Release automation
.github/workflows/ci.yml	CI workflow
.eslintrc.js	Legacy ESLint configuration

Review details

Suppressed comments (9)

lib/commands/show.js:174

• These truthiness checks mishandle legitimate zero counts: likes: 0 is omitted and dislikes: 0 is rendered as -. Check for null/undefined so the detail output reflects the API values.

  if (problem.likes)
    log.printf('* Likes:    %s', problem.likes);
  if (problem.dislikes)
    log.printf('* Dislikes: %s', problem.dislikes);
  else

lib/core.js:93

• This signature change leaves the submission -a caller at lib/commands/submission.js:134 using core.getProblems(callback) instead of (needTranslation, callback). The callback is then interpreted as the boolean argument and the real callback is missing, so bulk submission downloads fail when the chain invokes it; update that caller to pass !argv.dontTranslate first.
  lib/plugin.js:69
• The CLI's documented installers still use npm (bin/install and the Dockerfile), and no dependency or engine requirement ensures that pnpm is available to end users. A normal npm-installed CLI will therefore fail whenever it tries to install a missing plugin with pnpm add; use a package-manager-independent path or explicitly bootstrap/check pnpm.
  lib/plugins/leetcode.cn.js:138
• This new CN daily path uses the local checkError, which still maps both 401 and 403 to EXPIRED. A 403 from Cloudflare or rate limiting is not a session-expiry signal and should be reported as BLOCKED, consistent with the base plugin; otherwise the daily command reports the wrong failure and can trigger misleading re-login behavior.
  lib/plugins/leetcode.cn.js:138
• getProblemOfToday is not one of the methods wrapped by the retry plugin, so an expired CN session bypasses the automatic re-login path used by the other problem APIs and fails immediately. Add the new method to the retry wrapper list and cover its retry behavior.
  lib/plugins/leetcode.js:574
• The CN branch changes the spinner based on isCN, but this new failure message still tells CN users that password login was rejected by leetcode.com. Use the selected endpoint in the message so the remediation is accurate.
  lib/plugins/leetcode.js:643
• The response shim in lib/http.js exposes resp.request.uri.href but does not expose resp.request.headers.cookie. Consequently a successful third-party redirect reaches parseCookie(undefined) and reports invalid cookie?; preserve the jar's cookies or read them from a field the adapter actually provides.
  package.json:13
• The bin/pkg and bin/pkg.sh helpers still invoke npm run pkg, but this scripts block no longer defines a pkg script. Running the repository's packaging helper therefore fails with npm's missing-script error; restore a script matching the helper's target/output arguments or update both helpers to invoke the new binary directly.
  test/plugins/test_retry.js:109
• This new retry test still mocks and invokes getProblems with the old callback-only signature. The active plugin API is (needTranslation, cb), so the test does not verify forwarding of the translation flag and can pass while real callers use the wrong argument positions; update this test and the existing mocks to the new signature.

• Files reviewed: 65/70 changed files
• Comments generated: 12
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.