lib-index: mail-index-strmap - Fix OOB read from truncated record size - #304
Open
nishat-06 wants to merge 1 commit into
Open
lib-index: mail-index-strmap - Fix OOB read from truncated record size#304nishat-06 wants to merge 1 commit into
nishat-06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncated record size in mail_index_strmap_read_rec_first over-reads the block
A crafted or corrupted
dovecot.index.threadstrmap record can pick a packed count where the record byte sizecount * (sizeof(str_idx) + sizeof(crc32))overflows the 32-bitrec_sizefield: with n=0x20000001 the size 0x100000008 truncates to 8, soi_stream_read_bytes(input, ..., rec_size)accepts a tiny block while the code still walksstr_idx_base = data + count*sizeof(uint32_t)forward by ~2 GiB and readscountrecords past it. Wideningrec_sizetosize_tkeeps the real byte count, so an oversized record fails the stream read and is rejected as corruption, which is how the siblingdoveadm-dump-thread.cpath already treats the same quantity.