Release 1.34.10: web bind visibility and hardening - #113
Merged
Merged
Conversation
The 4.3.1 line is the GHSA-2883-xcg3-v3hh prototype-pollution fix. Pin the direct dependency and the override so Jest's copy cannot stay on 4.3.1. Co-authored-by: Doug Rathbone <dougrathbone@users.noreply.github.com>
onCommandError was assigned to initializationService.handleCommandError, and the MQTT router haDiscoveryTrigger/treeRequest events called into HaDiscovery, with no test that those two hops stay connected. Co-authored-by: Doug Rathbone <dougrathbone@users.noreply.github.com>
decodeLine was a 170-line if-ladder. Each verb now has a named handler so new panel events are a table entry rather than another branch in the preamble. Co-authored-by: Doug Rathbone <dougrathbone@users.noreply.github.com>
Node already uses 60s for headers and 300s for request inactivity. Set them from schema-backed standalone knobs with those same defaults so a slow client cannot hold a socket open indefinitely, without changing add-on options or shipped behaviour. Co-authored-by: Doug Rathbone <dougrathbone@users.noreply.github.com>
Message interval, command spacing, and publish-dedup cache bounds lived as magic numbers next to the schema that already owned the defaults. warnMin and warnMax on those entries are now the single source for the operator warnings. Co-authored-by: Doug Rathbone <dougrathbone@users.noreply.github.com>
C-Gate and MQTT still come up when the status port cannot bind, which left Home Assistant Ingress returning 502 with no other signal. Record listen state on the status payload, keep lifecycle reason web-bind-failed, and publish a diagnostic so the failure is visible over MQTT. Co-authored-by: Doug Rathbone <dougrathbone@users.noreply.github.com>
Co-authored-by: Doug Rathbone <dougrathbone@users.noreply.github.com>
dougrathbone
marked this pull request as ready for review
September 12, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardening batch for 1.34.10. Web UI bind failures stay isolated from C-Gate and MQTT but are now visible on the status payload and Home Assistant diagnostics. Also patches js-yaml, sets HTTP timeouts on the status server, drives config range warnings from schema metadata, and splits the Security decoder onto a verb table.
Changes
Test plan
npm testpasses locally with no failuresChecklist
package.jsonandhomeassistant-addon/config.yaml(if releasing)CHANGELOG.mdupdated (if releasing)