Skip to content

Fix official build WIF package publishing - #604

Merged
JoeRobich merged 1 commit into
mainfrom
fix/official-build-wif-auth
Sep 3, 2026
Merged

Fix official build WIF package publishing#604
JoeRobich merged 1 commit into
mainfrom
fix/official-build-wif-auth

Conversation

@JoeRobich

@JoeRobich JoeRobich commented Sep 3, 2026

Copy link
Copy Markdown
Member

The official build fails during pipeline validation because 1ES.PublishNuget@1 requires an ExternalNuGetFeed service connection, but dnceng-devdiv-vs-feed-push is a WIF-backed workloadidentityuser connection.

This ports the fix from dotnet/roslyn#84490:

  • authenticate to the DevDiv VS feed with NuGetAuthenticate@1
  • publish the shipping packages with dotnet nuget push using the credential provider
  • preserve package-conflict behavior with --skip-duplicate

Failed build: https://dev.azure.com/dnceng/internal/_build/results?buildId=3055126&view=results
Upstream fix: dotnet/roslyn@e7680f2

Test Build: https://dev.azure.com/dnceng/internal/_build/results?buildId=3065575&view=results

Authenticate to the DevDiv VS feed with NuGetAuthenticate and push packages with dotnet nuget so the WIF-backed service connection is not passed to an ExternalNuGetFeed-only task.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@JoeRobich
JoeRobich requested review from missymessa and tmat September 3, 2026 16:25

@missymessa missymessa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

Also, the pipeline should be pre-authorized to use whatever service connections it needs here, but let me know if you have any issues after this merges.

@JoeRobich

Copy link
Copy Markdown
Member Author

Also, the pipeline should be pre-authorized to use whatever service connections it needs here, but let me know if you have any issues after this merges.

It did need an approval but Haruna got us straightened out. Thanks!

@missymessa

Copy link
Copy Markdown
Member

Also, the pipeline should be pre-authorized to use whatever service connections it needs here, but let me know if you have any issues after this merges.

It did need an approval but Haruna got us straightened out. Thanks!

Of course he did, he's super fast :)

@JoeRobich
JoeRobich merged commit bd5ed3c into main Sep 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants