Add additional round-trip fixes and add additional unit tests for greater code coverage by jkoritzinsky · Pull Request #133188 · dotnet/runtime

jkoritzinsky · 2026-09-03T18:15:22Z

Creating a new PR to replace #131509.

azure-pipelines · 2026-09-03T18:16:14Z

Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-09-03T18:16:46Z

Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib
See info in area-owners.md if you want to be subscribed.

Copilot

Copilot review overview

🟡 Changes recommended

The CLI normalization refactor currently misclassifies value-taking options (using Option.Name vs aliases), and Options introduces a breaking public member rename that should be made compatible or internal.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1 · 1 · 1

New issues introduced by this change (3)

Severity	Finding
	`src/tools/ilasm/src/ilasm/NativeCommandLine.cs` — optionsWithValues is populated with Option.Name (e.g. "output"), but later checked against…
	`src/tools/ilasm/src/ILAssembler/Options.cs` — Options is a public type and this change replaces the existing public IsDll property with Dll.…
	`src/tools/ilasm/tests/ILAssembler.Tests/CommandLineTests.cs` — ModernValueOptions currently includes option.Name in addition to prefixed aliases. In…

What changed in this PR

This PR significantly expands the managed ilasm test suite and adjusts the managed IL assembler, test infrastructure, and CI/configuration to support additional IL round-trip scenarios (including a new managed-ilasm roundtrip), while fixing multiple metadata/PE emission and parsing edge cases uncovered by the added coverage.

Changes:

Add broad ILAssembler unit test coverage across metadata emission (typedefs/typerefs/exports/resources/events/properties/fields), parser robustness, preprocessor integration, and options/CLI behavior.
Update managed ilasm implementation to improve correctness/compatibility for opcode parsing, vararg/signature handling, PrivateScope naming, PE export/vtable fixup emission, and error-tolerant output behavior.
Extend CoreCLR test infrastructure/CI to support managedilasmroundtrip and introduce opt-out markers (ManagedIlasmRoundTripIncompatible) with accompanying documentation.

File	Description
src/tools/ilasm/tests/ILAssembler.Tests/TypeSignatureTests.cs	Adds tests for multi-dimensional array local signature shape decoding.
src/tools/ilasm/tests/ILAssembler.Tests/TypeReferenceTests.cs	Adds tests for typeref resolution scopes, mdtoken/.this/.base/.nester, module-scoped typerefs, and typelist parsing.
src/tools/ilasm/tests/ILAssembler.Tests/TypedefTests.cs	Adds typedef alias coverage for fields and custom attributes (including owner-scoped forms).
src/tools/ilasm/tests/ILAssembler.Tests/TypeDefinitionTests.cs	Adds tests for quoted name segments, class attribute flag behavior, nested types, and interface impl emission.
src/tools/ilasm/tests/ILAssembler.Tests/SyntaxTests.cs	Adds corpus-style tests ensuring malformed/truncated inputs report diagnostics instead of throwing.
src/tools/ilasm/tests/ILAssembler.Tests/SourceDirectiveTests.cs	Strengthens verification of escape processing and adds portable PDB directive coverage across variants/multi-doc scenarios.
src/tools/ilasm/tests/ILAssembler.Tests/SecurityTests.cs	Adds coverage for permissionset syntax variants, emitted DeclSecurity metadata, and error-tolerant behavior.
src/tools/ilasm/tests/ILAssembler.Tests/PropertyTests.cs	Adds tests for property attributes/accessors/custom attributes and indexed property signatures.
src/tools/ilasm/tests/ILAssembler.Tests/PropertyEventTests.cs	New tests validating property/event maps and MethodSemantics emission.
src/tools/ilasm/tests/ILAssembler.Tests/PreprocessorIntegrationTests.cs	New integration tests for includes, conditional compilation, and macro expansion across include levels.
src/tools/ilasm/tests/ILAssembler.Tests/ParameterTests.cs	Adds tests for parameter attribute syntaxes emitting expected flags.
src/tools/ilasm/tests/ILAssembler.Tests/NativeExportTests.cs	New tests validating PE export directory/stub emission and machine-specific stub prefixes.
src/tools/ilasm/tests/ILAssembler.Tests/ModuleTests.cs	Adds tests for `.file` metadata/resources, module refs, bare `.module`, and global method/module attribute + PDB emission.
src/tools/ilasm/tests/ILAssembler.Tests/ManifestResourceTests.cs	New tests for embedded/file/assembly-backed manifest resources and deterministic/error-tolerant behavior.
src/tools/ilasm/tests/ILAssembler.Tests/ILAssembler.Tests.csproj	Adds System.CommandLine dependency and links IlasmRootCommand.cs for CLI parsing tests.
src/tools/ilasm/tests/ILAssembler.Tests/FunctionPointerTests.cs	Switches to signature decoding assertions; adds vararg fnptr sentinel coverage.
src/tools/ilasm/tests/ILAssembler.Tests/FieldTests.cs	Adds tests for trailing custom attribute binding and field attribute flag/null constant emission.
src/tools/ilasm/tests/ILAssembler.Tests/ExportedTypeTests.cs	Adds coverage for ExportedType attributes/implementations/custom attributes and TypeDefId emission.
src/tools/ilasm/tests/ILAssembler.Tests/ExceptionHandlingTests.cs	Adds extensive EH region tests (offset-based, label-based, ordering, filter/fault/finally/catch).
src/tools/ilasm/tests/ILAssembler.Tests/EventTests.cs	Adds event accessor/attribute/other/custom-attr metadata tests and nil-type behavior.
src/tools/ilasm/tests/ILAssembler.Tests/DocumentCompilerTests.cs	New tests ensuring diagnostics have correct document paths and parser errors don’t leak scopes across documents.
src/tools/ilasm/tests/ILAssembler.Tests/DocumentCompilerTestHelpers.cs	Adds shared PEReader compile helper, token operand extraction, and metadata signature decoding provider.
src/tools/ilasm/tests/ILAssembler.Tests/DataTests.cs	Adds coverage for data directives (typed bytes, repeats, large bytearrays, float literals, syntax variants, error isolation).
src/tools/ilasm/tests/ILAssembler.Tests/CompilerOptionsTests.cs	New tests verifying Options-driven PE/metadata behavior, debug attributes, deterministic output, keyfile handling, and error-tolerant output.
src/tools/ilasm/tests/ILAssembler.Tests/CommandLineTests.cs	Updates modern option corpus generation to reflect IlasmRootCommand options (CLI normalization tests).
src/tools/ilasm/tests/ILAssembler.Tests/AssemblyTests.cs	Updates Options property name usage and adds additional assembly reference/identity/attribute parsing tests.
src/tools/ilasm/src/ILAssembler/VTableExportPEBuilder.cs	Fixes COR header vtable directory offset and improves vtable/export directory emission logic (including ordinal gaps).
src/tools/ilasm/src/ILAssembler/PreprocessedTokenSource.cs	Fixes include-stack EOF handling to avoid incorrectly popping the entry source.
src/tools/ilasm/src/ILAssembler/Options.cs	Renames the DLL output option property (public surface) and updates option model.
src/tools/ilasm/src/ILAssembler/NameHelpers.cs	Adds helper to normalize PrivateScope metadata names (strip `$PST` + token suffix).
src/tools/ilasm/src/ILAssembler/MetadataExtensions.cs	Adds ILOpCode.Unused support used by opcode parsing.
src/tools/ilasm/src/ILAssembler/gen/CIL.g4	Fixes token spelling and extends grammar for dotted names, mdtoken forms, unsigned native types, permissionset syntax, and opcode set.
src/tools/ilasm/src/ILAssembler/EntityRegistry.cs	Updates metadata emission behavior (PrivateScope naming, method body encoding heuristics, methodimpl owner, vararg sig rewriting, error-tolerant metadata row preservation).
src/tools/ilasm/src/ILAssembler/DocumentCompiler.cs	Enhances parser error context propagation so the visitor can avoid leaking state across erroneous contexts.
src/tools/ilasm/src/ILAssembler/Diagnostic.cs	Adds a new diagnostic ID/message for constraint owner out-of-range scenarios.
src/tools/ilasm/src/ilasm/Program.cs	Refactors CLI handling to use ParseResult explicitly and wires Normalize() with a single command instance.
src/tools/ilasm/src/ilasm/NativeCommandLine.cs	Refactors CLI normalization to derive supported options from IlasmRootCommand.
src/tools/ilasm/src/ilasm/IlasmRootCommand.cs	Removes embedded SetAction wiring (now configured from Program.Main).
src/tools/ilasm/src/ilasm/ilasm.csproj	Inlines NativeAOT runtime settings previously imported from AotCompilerCommon.props.
src/tests/Loader/classloader/regressions/dev10_403582/gentype.ilproj	Marks the project as incompatible with managed ilasm round-trip.
src/tests/Loader/classloader/regressions/dev10_403582/genmeth.ilproj	Marks the project incompatible with IL round-trip (and documents ildasm crash).
src/tests/Directory.Build.targets	Emits marker files for IlasmRoundTripIncompatible and ManagedIlasmRoundTripIncompatible.
src/tests/Common/CLRTest.Jit.targets	Adds marker-file based skipping and introduces managed-ilasm round-trip selection logic.
src/tests/Common/CLRTest.Execute.targets	Makes IlasmRoundTripIncompatible imply ManagedIlasmRoundTripIncompatible.
src/tests/Common/CLRTest.Execute.Batch.targets	Adds managed-ilasm-only skip logic for batch execution wrapper.
src/tests/Common/CLRTest.Execute.Bash.targets	Adds managed-ilasm-only skip logic for bash execution wrapper.
eng/pipelines/common/templates/runtimes/run-test-job.yml	Adds `managedilasmroundtrip` scenario to ilasm test group.
docs/workflow/testing/coreclr/test-configuration.md	Documents ManagedIlasmRoundTripIncompatible and the implication behavior.
docs/workflow/testing/coreclr/requiresprocessisolation.md	Updates guidance for IL round-trip incompatibility properties and isolation requirements.
docs/workflow/ci/disabling-tests.md	Documents disabling managed vs all ilasm round-trip and notes merged-runner behavior.

Copilot

Copilot review overview

🟡 Changes recommended

The new fat-header forcing logic in EntityRegistry can cause .maxstack-only methods (without .zeroinit) to emit InitLocals, altering semantics/metadata in a way that should be corrected or explicitly justified and locked in with tests.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 2

New issues introduced by this change (1)

Severity	Finding
	`src/tools/ilasm/src/ILAssembler/EntityRegistry.cs` — `forceFatHeader` triggers when `methodDef.MaxStack < 8` (i.e., `.maxstack` was explicitly…

Pre-existing issues (1)

Severity	Finding
	`src/tools/ilasm/src/ILAssembler/Options.cs` — Options is a public type and this change replaces the existing public IsDll property with Dll.… View comment

Issues resolved since last review (2)

Severity	Finding
	`src/tools/ilasm/tests/ILAssembler.Tests/CommandLineTests.cs` — ModernValueOptions currently includes option.Name in addition to prefixed aliases. In… View resolved comment
	`src/tools/ilasm/src/ilasm/NativeCommandLine.cs` — optionsWithValues is populated with Option.Name (e.g. "output"), but later checked against… View resolved comment

…ing. (#133202) The existing implementation was leading to file lock conflicts on #133188 and other managed ILASM PRs.

Copilot

Copilot review overview

🟡 Changes recommended

There are correctness issues in newly modified code paths (notably CLI normalization validation and method-body header emission) that can contradict the PR’s own tests/expected behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 4

New issues introduced by this change (2)

Severity	Finding
	`src/tools/ilasm/src/ILAssembler/EntityRegistry.cs` — The fallback body emission also forces `InitLocals` when `forceFatHeader` is true. That can change…
	`src/tools/ilasm/src/ilasm/NativeCommandLine.cs` — `-O:false` / `-g:true` / `-q:true` should be treated as valid modern short-option forms (the unit…

Pre-existing issues (2)

Severity	Finding
	`src/tools/ilasm/src/ILAssembler/EntityRegistry.cs` — `forceFatHeader` triggers when `methodDef.MaxStack < 8` (i.e., `.maxstack` was explicitly… View comment
	`src/tools/ilasm/src/ILAssembler/Options.cs` — Options is a public type and this change replaces the existing public IsDll property with Dll.… View comment

Suppressed comments (2)

src/tools/ilasm/src/ILAssembler/EntityRegistry.cs:387

When forceFatHeader is true, this code forces the InitLocals flag on even if the original IL didn’t request .locals init. That changes emitted method-body semantics/metadata; forcing a fat header should not require changing the InitLocals bit (you already pass hasDynamicStackAllocation || forceFatHeader to avoid a tiny header).

                        MethodBodyAttributes encodingAttributes = methodDef.BodyAttributes;
                        if (forceFatHeader)
                        {
                            encodingAttributes |= MethodBodyAttributes.InitLocals;
                        }

src/tools/ilasm/src/ILAssembler/EntityRegistry.cs:425

This fallback path forces InitLocals when forceFatHeader is true, which can change the emitted method-body header semantics (even for methods that didn’t specify .locals init). It should be possible to keep the original BodyAttributes and rely on hasDynamicStackAllocation || forceFatHeader to force a fat header when needed.

                            localsSigHandle,
                            forceFatHeader ? methodDef.BodyAttributes | MethodBodyAttributes.InitLocals : methodDef.BodyAttributes,
                            hasDynamicStackAllocation: methodDef.HasDynamicStackAllocation || forceFatHeader);

Copilot

Copilot review overview

🔵 Needs a closer look

It spans low-level PE/metadata emission, grammar/parser behavior, test-harness execution logic, and CI scenario expansion, which warrants human validation of compatibility and unintended behavioral changes.

Review tier: Lite
Findings: 4

Pre-existing issues (4)

Severity	Finding
	`src/tools/ilasm/src/ilasm/NativeCommandLine.cs` — `-O:false` / `-g:true` / `-q:true` should be treated as valid modern short-option forms (the unit… View comment
	`src/tools/ilasm/src/ILAssembler/EntityRegistry.cs` — The fallback body emission also forces `InitLocals` when `forceFatHeader` is true. That can change… View comment
	`src/tools/ilasm/src/ILAssembler/EntityRegistry.cs` — `forceFatHeader` triggers when `methodDef.MaxStack < 8` (i.e., `.maxstack` was explicitly… View comment
	`src/tools/ilasm/src/ILAssembler/Options.cs` — Options is a public type and this change replaces the existing public IsDll property with Dll.… View comment

Allow tests to opt out of managed ilasm round trips while preserving native ilasm coverage, and make the existing all-round-trip exclusion imply the managed-only property. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 286b5b04-7d1b-4228-ad6b-dac025ce91a7

…ely product changes. Make the necessary fixes to the GrammarVisitor model to get these tests passing

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Clamp synthetic token spans and use inclusive token lengths so EOF diagnostics never report negative ranges. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Remove the redundant shared-library marker explanation for general ilasm round trips. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Drop the shared-library implementation detail from the managed ilasm round-trip configuration guidance. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Clarified that shared-library projects do not need process isolation for the property related to disabling tests. Added a note that these workarounds are temporary until bugs are fixed.

Explain the coupling between the custom PE builder's COR header offset and System.Reflection.Metadata's managed text layout. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Match native ilasm's observable InitLocals behavior for short localloc methods whose ildasm text cannot otherwise represent the original header flag. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Runtime test assets are built architecture-neutral, so emit the temporary x86 OOM exclusions without TargetArchitecture conditions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Simplify native fat-header compatibility, conservatively preserve InitLocals through the encoder, remove redundant localloc tracking, and unify OOM exclusion descriptions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Managed ilasm exceeds practical memory limits while assembling HugeField1, so emit the same unconditional marker used by the other OOM cases. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Skip HugeField2 and hugeSimpleExpr1 during managed ilasm round-trip validation because both exceed practical CI memory limits. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Copilot

Copilot review overview

🔵 Needs a closer look

Parser diagnostics, quoted-name handling, and generated ANTLR sources still need correction.

Review effort: Lite
Findings: None

Resolved since last review (1)

Handle standalone quoted names in the visitor

jkotas · 2026-09-21T20:39:47Z

-            Machine.Arm64 => 12,  // adrp x16, addr; ldr x16, [x16]; br x16
-            _ => 0
+            Machine.Unknown => Machine.I386,
+            Machine.Arm => Machine.ArmThumb2,


Suggested change

Machine.Arm => Machine.ArmThumb2,

We should not ever see Machine.Arm here

jkotas · 2026-09-21T20:55:05Z

+        [Fact]
+        public void VTableFixupAndExport_UseDeclaredWritableDataAndExecutableStubs()
+        {
+            string source = """


Native ilasm fails to compile this with:

x.il(3) : error : syntax error at token 'int32' in: .data VT = int32(0) int32(0)

Is this fixing bugs that are present in native ilasm? We may want to track the list of native ilasm bugs fixed in managed ilasm in a .md file for reference.

jkotas · 2026-09-21T20:57:31Z

+            Machine.Amd64 or
+            Machine.IA64 or
+            Machine.Arm64 or
+            Machine.LoongArch64 or


Can we handle the current Windows architectures only here and throw unrechable for the rest?

Otherwise, we will see every new port growing these lists.

jkotas · 2026-09-21T21:07:45Z

        private static bool IsCoreLibAssemblyName(string name)
        {
-            return name is "mscorlib" or "System.Runtime" or "System.Private.CoreLib" or "netstandard";
+            return name is "mscorlib" or "System.Runtime" or "System.Private.CoreLib";


Should this stay? (Another native ilasm bug fix?)

jkotas · 2026-09-21T21:27:42Z

+            const int TokenLength = 8;
+            const string PrivateScopeMarker = "$PST";
+            int markerIndex = name.Length - PrivateScopeMarker.Length - TokenLength;
+            if (markerIndex < 0)


This looks like another native ilasm bug fix - native ilasm looks for $PST06 or $PST04 anywhere in the name.

jkotas · 2026-09-21T21:59:56Z

                    }
                    catch (ArgumentOutOfRangeException)
                    {
                        // Exception handler regions have invalid ranges (e.g., from parse


Add TODO that this needs fixing to maintain ilasm ability to produce invalid output. (Related to discussion at #131507 (comment) )

jkotas · 2026-09-21T22:14:50Z

+                }
+
+                ReportError(
+                    DiagnosticIds.GenericParameterConstraintOwnerOutOfRange,


(This can be also mentioned as managed ilasm bug fix.)

jkoritzinsky added the area-ILTools-coreclr label Sep 3, 2026

dotnet-policy-service Bot assigned jkoritzinsky Sep 3, 2026

github-project-automation Bot added this to AppModel Sep 3, 2026

Copilot AI lite review requested due to automatic review settings September 3, 2026 18:19

Copilot started reviewing on behalf of jkoritzinsky September 3, 2026 18:20 View session

Copilot AI reviewed Sep 3, 2026

View reviewed changes

Comment thread src/tools/ilasm/src/ilasm/NativeCommandLine.cs Outdated

Comment thread src/tools/ilasm/src/ILAssembler/Options.cs

Comment thread src/tools/ilasm/tests/ILAssembler.Tests/CommandLineTests.cs

This was referenced Sep 3, 2026

Convert AssemblyChecker to use MetadataLoadContext to avoid file locking. #133202

Merged

[ci-scan] Test failure: JitTest_Directed_nullabletypes_gettype.P.BoxedNullableGetType #133207

Closed

build-analysis Bot mentioned this pull request Sep 4, 2026

HttpMetricsTest_Http20.TimeInQueue_RecordedForNewConnectionsOnly test failure #122522

Open

Copilot AI review requested due to automatic review settings September 4, 2026 15:28

Copilot started reviewing on behalf of jkoritzinsky September 4, 2026 15:29 View session

Copilot AI reviewed Sep 4, 2026

View reviewed changes

Comment thread src/tools/ilasm/src/ILAssembler/EntityRegistry.cs Outdated

jkoritzinsky added a commit that referenced this pull request Sep 4, 2026

Convert AssemblyChecker to use MetadataLoadContext to avoid file lock…

78189fa

…ing. (#133202) The existing implementation was leading to file lock conflicts on #133188 and other managed ILASM PRs.

build-analysis Bot mentioned this pull request Sep 4, 2026

Test failure: GC/Features/HeapExpansion/bestfit-finalize/bestfit-finalize.cmd #132107

Open

Base automatically changed from ilasm-fixups to main September 9, 2026 16:42

Copilot AI review requested due to automatic review settings September 9, 2026 16:42

jkoritzinsky force-pushed the ilasm-more-tests branch from 808dadd to b7476ab Compare September 9, 2026 16:42

Copilot started reviewing on behalf of jkoritzinsky September 9, 2026 16:43 View session

Copilot AI reviewed Sep 9, 2026

View reviewed changes

Comment thread src/tools/ilasm/src/ILAssembler/EntityRegistry.cs Outdated

Comment thread src/tools/ilasm/src/ilasm/NativeCommandLine.cs Outdated

build-analysis Bot mentioned this pull request Sep 9, 2026

Test failure: SocketBlockingModeTransitionTests.ConnectAsync_WithBuffer_Succeeds fails intermittently on Linux #133012

Closed

jkotas reviewed Sep 9, 2026

View reviewed changes

Comment thread docs/workflow/ci/disabling-tests.md

Copilot AI review requested due to automatic review settings September 9, 2026 22:29

jkoritzinsky force-pushed the ilasm-more-tests branch from b7476ab to b5eee55 Compare September 9, 2026 22:29

Copilot started reviewing on behalf of jkoritzinsky September 9, 2026 22:30 View session

Copilot AI reviewed Sep 9, 2026

View reviewed changes

jkoritzinsky and others added 23 commits September 18, 2026 13:55

Fix build failures and deduplicate logic

0a12521

Port down tests from the ilasm-actions branch so that PR can be entir…

462d27d

…ely product changes. Make the necessary fixes to the GrammarVisitor model to get these tests passing

Add one more test from upstack

2e3c055

Restore running round-trip

94bc156

Fix ilasm option alias handling

18c7f4b

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Mark managed ilasm-incompatible tests

9bf1465

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Fix build failure

57c3fcc

Skip ARM hardware intrinsics in managed ilasm round trip

9685c8a

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Address additional ilasm review feedback

b05dadd

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Preserve numeric branch offsets in ilasm

ca2cf80

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Fix managed ilasm native export emission

c670b93

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Address remaining ilasm review feedback

8f2232b

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Fix preprocessor diagnostic spans

2341314

Clamp synthetic token spans and use inclusive token lengths so EOF diagnostics never report negative ranges. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Trim ilasm test configuration guidance

d03ddfa

Remove the redundant shared-library marker explanation for general ilasm round trips. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Remove managed ilasm marker detail

6482030

Drop the shared-library implementation detail from the managed ilasm round-trip configuration guidance. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 806a996a-9fcc-42b7-a902-cac954582b24

Update disabling tests documentation with clarifications

f63ca1e

Clarified that shared-library projects do not need process isolation for the property related to disabling tests. Added a note that these workarounds are temporary until bugs are fixed.

Copilot AI review requested due to automatic review settings September 19, 2026 18:59

jkoritzinsky force-pushed the ilasm-more-tests branch from e535ca0 to 89f3243 Compare September 19, 2026 18:59

Copilot started reviewing on behalf of jkoritzinsky September 19, 2026 18:59 View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

This was referenced Sep 19, 2026

XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796

Open

[ci-scan] Test failure: HandleEventShutdownInitiatedByTransport fails with QuicException : The connection timed out from inactivity. #133373

Open

jkotas reviewed Sep 21, 2026

View reviewed changes

Conversation

jkoritzinsky commented Sep 3, 2026

Uh oh!

azure-pipelines Bot commented Sep 3, 2026

Uh oh!

dotnet-policy-service Bot commented Sep 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

jkotas Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants