Skip to content

Create a simple dashboard to view all pull requests by who should review them#774

Open
jasonmalinowski wants to merge 9 commits intodotnet:mainfrom
jasonmalinowski:code-review-dashboard
Open

Create a simple dashboard to view all pull requests by who should review them#774
jasonmalinowski wants to merge 9 commits intodotnet:mainfrom
jasonmalinowski:code-review-dashboard

Conversation

@jasonmalinowski
Copy link
Copy Markdown
Member

Comment thread src/GitHubCodeReviewDashboard/GitHubCodeReviewDashboard/Dashboard.cs Outdated
var github = new GitHubClient(new ProductHeaderValue("dotnet-roslyn-Code-Review-Dashboard"));
github.Credentials = new Credentials(Startup.GitHubToken);
var openPullRequests = await GetAllPullRequests(github);
var ideTeamMembers = (await github.Organization.Team.GetAllMembers(1781706)).Select(u => u.Login).ToList();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constant?

}

pullRequests.Add(pullRequest);
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to bottom

Comment thread src/GitHubCodeReviewDashboard/GitHubCodeReviewDashboard/Dashboard.cs Outdated
Comment thread src/GitHubCodeReviewDashboard/GitHubCodeReviewDashboard/Pages/Index.cshtml Outdated

public void OnGet()
{
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

-->
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<WebPublishMethod>MSDeploy</WebPublishMethod>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's you deploy straight to Azure from the UI. This file is mostly autogenerated.

<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<WebPublishMethod>MSDeploy</WebPublishMethod>
<IsLinux>true</IsLinux>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:'(

@@ -0,0 +1,46 @@
using Microsoft.AspNetCore.Builder;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyrights?

"Microsoft.Hosting.Lifetime": "Information"
}
},
"AllowedHosts": "*"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@jasonmalinowski jasonmalinowski self-assigned this May 11, 2020
@jasonmalinowski jasonmalinowski force-pushed the code-review-dashboard branch from 15824d8 to 20f631e Compare May 11, 2020 23:58
@@ -0,0 +1,81 @@
using Octokit;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need license headers for this repo?

Base automatically changed from master to main March 5, 2021 16:44
@JoeRobich
Copy link
Copy Markdown
Member

@jasonmalinowski Do we want to move forward with this PR?

@jasonmalinowski
Copy link
Copy Markdown
Member Author

@JoeRobich Hmm, yeah, I should merge this. I had deployed it to Azure as a test, which I need to fix up after some subscription changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants