Skip to content

Update action.yml inputs and descriptions - #808

Closed
gewarren wants to merge 4 commits into
mainfrom
gewarren-patch-7
Closed

gewarren wants to merge 4 commits into
mainfrom
gewarren-patch-7

Conversation

@gewarren

@gewarren gewarren commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Removed some functions from the input description and added a new input for excluding include files.

Removed some functions from the input description and added a new input for excluding include files.
Copilot AI balanced review requested due to automatic review settings November 4, 2026 20:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The exclusion input is passed as a scalar rather than the indexed list the application expects, leaving supposedly protected include files vulnerable to deletion, which is enabled by default.

1 open issue
What changed in this PR

This PR updates the Clean repo GitHub Action’s input metadata and adds an input intended to protect include files from orphan cleanup.

Changes:

  • Removes three image-processing functions from the function description.
  • Adds exclude_include_files and forwards its value to the CLI.
File Description
cleanrepo/​action.yml Updates the function description and adds the include-file exclusion input and argument.

Review effort: Balanced

Comment thread cleanrepo/action.yml Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Omitting the optional input triggers fromJSON(''), causing argument evaluation to fail before the container starts and breaking existing workflows.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread cleanrepo/action.yml Resolved
Comment thread cleanrepo/action.yml Resolved
Comment thread cleanrepo/action.yml Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The unquoted [] default in cleanrepo/action.yml is a YAML sequence rather than a required string, making the action metadata invalid and preventing the action from loading.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread cleanrepo/action.yml Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new [] default produces an array where Docker runs.args requires a string, causing argument evaluation to fail before container startup even for existing workflows that omit exclude_include_files.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread cleanrepo/action.yml
- '/Options:UrlBasePath'
- ${{ inputs.url_base_path }}
- '/Options:ExcludeOrphanedIncludeFiles'
- ${{ fromJSON(inputs.exclude_include_files) }}
@gewarren gewarren closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants