Repository navigation
Conversation
Removed some functions from the input description and added a new input for excluding include files.
There was a problem hiding this comment.
🟡 Changes recommended
The exclusion input is passed as a scalar rather than the indexed list the application expects, leaving supposedly protected include files vulnerable to deletion, which is enabled by default.
1 open issue
What changed in this PR
This PR updates the Clean repo GitHub Action’s input metadata and adds an input intended to protect include files from orphan cleanup.
Changes:
- Removes three image-processing functions from the
functiondescription. - Adds
exclude_include_filesand forwards its value to the CLI.
| File | Description |
|---|---|
cleanrepo/action.yml |
Updates the function description and adds the include-file exclusion input and argument. |
Review effort: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
The unquoted [] default in cleanrepo/action.yml is a YAML sequence rather than a required string, making the action metadata invalid and preventing the action from loading.
1 open issue
1 resolved since last review
Review effort: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
The new [] default produces an array where Docker runs.args requires a string, causing argument evaluation to fail before container startup even for existing workflows that omit exclude_include_files.
1 open issue
1 resolved since last review
Review effort: Balanced
| - '/Options:UrlBasePath' | ||
| - ${{ inputs.url_base_path }} | ||
| - '/Options:ExcludeOrphanedIncludeFiles' | ||
| - ${{ fromJSON(inputs.exclude_include_files) }} |

Removed some functions from the input description and added a new input for excluding include files.