Repository navigation
Benchmark TryParseRequestHeader instead of the obsolete entry points - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark harness still called
TryExtractFullHeaderROMandTryExtractFullHeaderValidated, which have been obsolete since #81. Building the solution printed CS0618 warnings for both calls.TryParseRequestHeader.request.Clear()first. Since Clear the parse target before filling it #76 the parser clears its target itself, so the benchmark was clearing it twice.After this change, the solution builds with no CS0618 warnings. One run on an i9-14900K pinned to one P-core (.NET 10) stays within 4% of the README's tables: