server:start: Doppar banner and per-request log with execution time - #346
Open
techmahedy wants to merge 1 commit into
Open
techmahedy wants to merge 1 commit into
techmahedy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Summary
php pool server:startnow prints the Doppar logo with the framework version on startup, and shows one clean line per request: status and request on the left, execution time on the right.Before, the output was PHP's raw built-in server log, with three lines per connection and no timing:
After:
Screenshot
Files
src/Phaseolies/Console/Commands/Server/ServerStartCommand.php: banner, output parsing, request rendering.src/Phaseolies/Console/Commands/Server/request_logger.stub: new, the prepended per-request script.Compatibility
server:startarguments and options are the same.server:startstdout, the format changed.Symfony\Component\Console\TerminalandOutputFormatterare already dependencies.Checklist